luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 03:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Drop dead code in GVariant parser

Browse Source 
There is no chance that an unsigned integer value will be negative after
we do the bounds check that enforces its non-negativity.

Caught by Matthias running Coverity.
This commit is contained in:
Ryan Lortie 2011-06-14 22:44:10 -04:00
parent a6b9db6907
commit 23f684454f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
glib/gvariant-parser.c
View File

@ -1886,7 +1886,7 @@ number_get_value (AST *ast,
case 'q':
if (negative || abs_val > G_MAXUINT16)
return number_overflow (ast, type, error);
return g_variant_new_uint16 (negative ? -abs_val : abs_val);
return g_variant_new_uint16 (abs_val);
case 'i':
if (abs_val - negative > G_MAXINT32)
@ -1896,7 +1896,7 @@ number_get_value (AST *ast,
case 'u':
if (negative || abs_val > G_MAXUINT32)
return number_overflow (ast, type, error);
return g_variant_new_uint32 (negative ? -abs_val : abs_val);
return g_variant_new_uint32 (abs_val);
case 'x':
if (abs_val - negative > G_MAXINT64)
@ -1906,7 +1906,7 @@ number_get_value (AST *ast,
case 't':
if (negative)
return number_overflow (ast, type, error);
return g_variant_new_uint64 (negative ? -abs_val : abs_val);
return g_variant_new_uint64 (abs_val);
case 'h':
if (abs_val - negative > G_MAXINT32)