luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 11:26:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

deprecated threads: fix race in GStaticRecMutex

Browse Source 
The very last access to the 'depth' field of GStaticRecMutex in
g_static_rec_mutex_unlock_full() was being performed after dropping the
implementation mutex for the last time.

This allowed the lock to be dropped an additional time if it was
acquired in another thread right at that instant (which is somewhat
likely, since another thread could have just been woken up by the lock
being released).

https://bugzilla.gnome.org/show_bug.cgi?id=670846
This commit is contained in:
Mark Janossy 2012-03-09 09:54:23 -05:00 committed by Ryan Lortie
parent cb44e96dfa
commit 265f265c67
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
glib/deprecated/gthread-deprecated.c
View File

@ -807,14 +807,17 @@ g_static_rec_mutex_unlock_full (GStaticRecMutex *mutex)
{
GRecMutex *rm;
gint depth;
gint i;
rm = g_static_rec_mutex_get_rec_mutex_impl (mutex);
/* all access to mutex->depth done while still holding the lock */
depth = mutex->depth;
while (mutex->depth)
{
mutex->depth--;
g_rec_mutex_unlock (rm);
}
i = mutex->depth;
mutex->depth = 0;
while (i--)
g_rec_mutex_unlock (rm);
return depth;
}