luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-14 19:55:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

gbookmarkfile: Fix some more minor leaks when metadata elements are repeated

Browse Source 
oss-fuzz#9723

Signed-off-by: Philip Withnall <withnall@endlessm.com>
This commit is contained in:
Philip Withnall 2018-08-06 13:36:21 +01:00
parent 0fba231a6b
commit 2860d4b50e
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
glib/gbookmarkfile.c
View File

@ -863,7 +863,8 @@ parse_application_element (GMarkupParseContext *context,
item->metadata->applications = g_list_prepend (item->metadata->applications, ai); item->metadata->applications = g_list_prepend (item->metadata->applications, ai);
g_hash_table_replace (item->metadata->apps_by_name, ai->name, ai); g_hash_table_replace (item->metadata->apps_by_name, ai->name, ai);
} }
g_free (ai->exec);
ai->exec = g_strdup (exec); ai->exec = g_strdup (exec);
if (count) if (count)

1
glib/tests/Makefile.am
View File

@ -165,6 +165,7 @@ dist_test_data += \
bookmarks/fail-37.xbel \ bookmarks/fail-37.xbel \
bookmarks/fail-38.xbel \ bookmarks/fail-38.xbel \
bookmarks/fail-39.xbel \ bookmarks/fail-39.xbel \
bookmarks/fail-40.xbel \
bookmarks/valid-01.xbel \ bookmarks/valid-01.xbel \
bookmarks/valid-02.xbel \ bookmarks/valid-02.xbel \
bookmarks/valid-03.xbel \ bookmarks/valid-03.xbel \

1
glib/tests/bookmarks/fail-40.xbel Normal file
View File

@ -0,0 +1 @@
<xbel version="1.0"><bookmark href=""><info><metadata owner="http://freedesktop.org"><applications><application name=""exec=""/><application name=""exec=""/