luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-11-01 00:42:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

gmain: Do atomic addition before checking the old value on ref

Browse Source 
So we avoid working on a value that is not been updated yet.
This commit is contained in:
Marco Trevisan (Treviño)
2022-06-21 05:01:55 +02:00
parent bfd77693ce
commit 2c322f2a65
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
glib/gmain.c
View File

@@ -551,10 +551,12 @@ GSourceFuncs g_idle_funcs =
GMainContext *
g_main_context_ref (GMainContext *context)
{
g_return_val_if_fail (context != NULL, NULL);
g_return_val_if_fail (g_atomic_int_get (&context->ref_count) > 0, NULL);
int old_ref_count;
g_atomic_int_inc (&context->ref_count);
g_return_val_if_fail (context != NULL, NULL);
old_ref_count = g_atomic_int_add (&context->ref_count, 1);
g_return_val_if_fail (old_ref_count > 0, NULL);
return context;
}