luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-09-20 01:06:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add some tests for off-by-one errors.

Browse Source 
2004-04-22  Matthias Clasen  <mclasen@redhat.com>

	* tests/queue-test.c (main): Add some tests for off-by-one errors.

	* glib/gqueue.c (g_queue_pop_nth_link): Fix an off-by-one
	error.  (#139703, Philippe Blain)
This commit is contained in:
Matthias Clasen 2004-04-22 20:51:07 +00:00 committed by Matthias Clasen
parent 05501852ec
commit 2efb5e1cd8
8 changed files with 47 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,5 +1,10 @@
2004-04-22 Matthias Clasen <mclasen@redhat.com>
* tests/queue-test.c (main): Add some tests for off-by-one errors.
* glib/gqueue.c (g_queue_pop_nth_link): Fix an off-by-one
error. (#139703, Philippe Blain)
* tests/testglib.c (main): Add testcases for g_message() involving
non-printable and unsafe characters.

5
ChangeLog.pre-2-10
View File

@ -1,5 +1,10 @@
2004-04-22 Matthias Clasen <mclasen@redhat.com>
* tests/queue-test.c (main): Add some tests for off-by-one errors.
* glib/gqueue.c (g_queue_pop_nth_link): Fix an off-by-one
error. (#139703, Philippe Blain)
* tests/testglib.c (main): Add testcases for g_message() involving
non-printable and unsafe characters.

5
ChangeLog.pre-2-12
View File

@ -1,5 +1,10 @@
2004-04-22 Matthias Clasen <mclasen@redhat.com>
* tests/queue-test.c (main): Add some tests for off-by-one errors.
* glib/gqueue.c (g_queue_pop_nth_link): Fix an off-by-one
error. (#139703, Philippe Blain)
* tests/testglib.c (main): Add testcases for g_message() involving
non-printable and unsafe characters.

5
ChangeLog.pre-2-4
View File

@ -1,5 +1,10 @@
2004-04-22 Matthias Clasen <mclasen@redhat.com>
* tests/queue-test.c (main): Add some tests for off-by-one errors.
* glib/gqueue.c (g_queue_pop_nth_link): Fix an off-by-one
error. (#139703, Philippe Blain)
* tests/testglib.c (main): Add testcases for g_message() involving
non-printable and unsafe characters.

5
ChangeLog.pre-2-6
View File

@ -1,5 +1,10 @@
2004-04-22 Matthias Clasen <mclasen@redhat.com>
* tests/queue-test.c (main): Add some tests for off-by-one errors.
* glib/gqueue.c (g_queue_pop_nth_link): Fix an off-by-one
error. (#139703, Philippe Blain)
* tests/testglib.c (main): Add testcases for g_message() involving
non-printable and unsafe characters.

5
ChangeLog.pre-2-8
View File

@ -1,5 +1,10 @@
2004-04-22 Matthias Clasen <mclasen@redhat.com>
* tests/queue-test.c (main): Add some tests for off-by-one errors.
* glib/gqueue.c (g_queue_pop_nth_link): Fix an off-by-one
error. (#139703, Philippe Blain)
* tests/testglib.c (main): Add testcases for g_message() involving
non-printable and unsafe characters.

2
glib/gqueue.c
View File

@ -662,7 +662,7 @@ g_queue_pop_nth_link (GQueue *queue,
g_return_val_if_fail (queue != NULL, NULL);
if (n > queue->length)
if (n >= queue->length)
return NULL;
link = g_queue_peek_nth_link (queue, n);

18
tests/queue-test.c
View File

@ -927,14 +927,28 @@ int main(int argc, gchar *args[])
g_queue_foreach (q2, remove_item, q2);
check_integrity (q2);
check_integrity (q);
/* some checks for off by one errors */
g_queue_push_tail (q, GINT_TO_POINTER (1234));
check_integrity (q);
node = g_queue_peek_tail_link (q);
g_assert (node != NULL && node->data == GINT_TO_POINTER (1234));
node = g_queue_peek_nth_link (q, g_queue_get_length (q));
g_assert (node == NULL);
node = g_queue_peek_nth_link (q, g_queue_get_length (q) - 1);
g_assert (node->data == GINT_TO_POINTER (1234));
node = g_queue_pop_nth_link (q, g_queue_get_length (q));
g_assert (node == NULL);
node = g_queue_pop_nth_link (q, g_queue_get_length (q) - 1);
g_assert (node != NULL && node->data == GINT_TO_POINTER (1234));
g_queue_free (q);
if (argc > 1)
random_test (strtol (args[1], NULL, 0));
else
random_test (time (0));
random_test (time (0));
return 0;
}