luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-26 22:16:16 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests: Make g_aligned_alloc tests fail if preconditions aren't checked

Browse Source 
Previously, these tests would always pass. If the precondition check
failed (as we want it to), the subprocess would exit unsuccessfully;
but if the precondition check wrongly passed, the subprocess would
continue, allocate a nonzero amount of memory, and fail the
g_assert_null(), resulting in the subprocess exiting unsuccessfully
and the test still passing.

Signed-off-by: Simon McVittie <smcv@collabora.com>
This commit is contained in:
Simon McVittie 2022-02-15 10:52:59 +00:00
parent d04f3491af
commit 38cdfe3c02
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
glib/tests/utils.c
View File

@ -922,7 +922,7 @@ aligned_alloc_nz (void)
/* Test an alignment that’s zero */
a = g_aligned_alloc (16, sizeof(char), 0);
g_assert_null (a);
g_aligned_free (a);
exit (0);
}
@ -933,7 +933,7 @@ aligned_alloc_npot (void)
/* Test an alignment that’s not a power of two */
a = g_aligned_alloc (16, sizeof(char), 15);
g_assert_null (a);
g_aligned_free (a);
exit (0);
}
@ -944,7 +944,7 @@ aligned_alloc_nmov (void)
/* Test an alignment that’s not a multiple of sizeof(void*) */
a = g_aligned_alloc (16, sizeof(char), sizeof(void *) / 2);
g_assert_null (a);
g_aligned_free (a);
exit (0);
}