luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-26 14:06:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

gresolver: Don’t use gai_strerror() on Windows, as it isn’t threadsafe

Browse Source 
Instead, use WSAGetLastError().

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #1732
This commit is contained in:
Philip Withnall 2019-03-21 11:51:37 +00:00
parent ff47bb0e53
commit 3a11213b68
2 changed files with 32 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gio/gresolver.c
View File

@ -340,9 +340,19 @@ handle_ip_address (const char *hostname,
if (inet_aton (hostname, &ip4addr))
#endif
{
#ifdef G_OS_WIN32
gchar *error_message = g_win32_error_message (WSAHOST_NOT_FOUND);
#else
const gchar *error_message = gai_strerror (EAI_NONAME);
#endif
g_set_error (error, G_RESOLVER_ERROR, G_RESOLVER_ERROR_NOT_FOUND,
_("Error resolving “%s”: %s"),
hostname, gai_strerror (EAI_NONAME));
hostname, error_message);
#ifdef G_OS_WIN32
g_free (error_message);
#endif
return TRUE;
}

23
gio/gthreadedresolver.c
View File

@ -154,11 +154,21 @@ do_lookup_by_name (GTask *task,
}
else
{
#ifdef G_OS_WIN32
gchar *error_message = g_win32_error_message (WSAGetLastError ());
#else
const gchar *error_message = gai_strerror (retval);
#endif
g_task_return_new_error (task,
G_RESOLVER_ERROR,
g_resolver_error_from_addrinfo_error (retval),
_("Error resolving “%s”: %s"),
hostname, gai_strerror (retval));
hostname, error_message);
#ifdef G_OS_WIN32
g_free (error_message);
#endif
}
if (res)
@ -310,14 +320,23 @@ do_lookup_by_address (GTask *task,
{
gchar *phys;
#ifdef G_OS_WIN32
gchar *error_message = g_win32_error_message (WSAGetLastError ());
#else
const gchar *error_message = gai_strerror (retval);
#endif
phys = g_inet_address_to_string (address);
g_task_return_new_error (task,
G_RESOLVER_ERROR,
g_resolver_error_from_addrinfo_error (retval),
_("Error reverse-resolving “%s”: %s"),
phys ? phys : "(unknown)",
gai_strerror (retval));
error_message);
g_free (phys);
#ifdef G_OS_WIN32
g_free (error_message);
#endif
}
}