luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-27 06:26:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

gtestutils.h: Fix warning with -Wsign-conversion caused by g_assert_cmpint

Browse Source 
With gcc and clang using -Wsign-conversion a related warning is generated
if code using glib 2.78.0 contains function g_assert_cmpint().

Warning is fixed by adding related casts. Related tests have been also
updated and will be also compiled with -Wsign-conversion to detect
related problems in future.
This commit is contained in:
Hannes Müller 2023-09-22 08:54:48 +02:00
parent 41c9c51080
commit 3cb79ee261
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glib/gtestutils.h
View File

@ -54,7 +54,7 @@ typedef void (*GTestFixtureFunc) (gpointer fixture,
gint64 __n1 = (n1), __n2 = (n2); \
if (__n1 cmp __n2) ; else \
g_assertion_message_cmpint (G_LOG_DOMAIN, __FILE__, __LINE__, G_STRFUNC, \
#n1 " " #cmp " " #n2, __n1, #cmp, __n2, 'i'); \
#n1 " " #cmp " " #n2, (guint64)__n1, #cmp, (guint64)__n2, 'i'); \
} G_STMT_END
#define g_assert_cmpuint(n1, cmp, n2) G_STMT_START { \
guint64 __n1 = (n1), __n2 = (n2); \

7
glib/tests/meson.build
View File

@ -138,6 +138,13 @@ glib_tests = {
'args': [ '--verbose' ],
'extra_programs' : ['testing-helper'],
},
'testing-macro' : {
'args': [ '--verbose' ],
'extra_programs' : ['testing-helper'],
'source' : 'testing.c',
'c_args' : cc.get_id() == 'gcc' ? ['-Werror=sign-conversion'] : [],
'install' : false,
},
'test-printf' : {},
'thread' : {},
'thread-deprecated' : {},

2
glib/tests/testing.c
View File

@ -486,7 +486,7 @@ test_random_conversions (void)
int vint = g_test_rand_int();
char *err, *str = g_strdup_printf ("%d", vint);
gint64 vint64 = g_ascii_strtoll (str, &err, 10);
g_assert_cmphex (vint, ==, vint64);
g_assert_cmpint (vint, ==, vint64);
g_assert_true (!err || *err == 0);
g_free (str);
}