luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-04 10:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

notifyqueue: Dedup pspecs when adding

Browse Source 
The previous code dedup'd when thawing and threw nasty warnings your way
if you notified too often. This can now easily be avoided.

Performance should be roughly identical, as both are O(n²).
This commit is contained in:
Benjamin Otte 2010-08-06 23:15:28 +02:00
parent e88eb04865
commit 4ac7f8f084
1 changed files with 7 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
gobject/gobjectnotifyqueue.c
View File

@ -119,22 +119,10 @@ g_object_notify_queue_thaw (GObject *object,
}
pspecs = nqueue->n_pspecs > 16 ? free_me = g_new (GParamSpec*, nqueue->n_pspecs) : pspecs_mem;
/* set first entry to NULL since it's checked unconditionally */
pspecs[0] = NULL;
for (slist = nqueue->pspecs; slist; slist = slist->next)
{
GParamSpec *pspec = slist->data;
guint i;
/* dedup, make pspecs in the list unique */
for (i = 0; i < n_pspecs; i++)
{
if (pspecs[i] == pspec)
break;
}
if (i == n_pspecs) /* if no match was found */
pspecs[n_pspecs++] = pspec;
pspecs[n_pspecs++] = slist->data;
}
g_datalist_id_set_data (&object->qdata, context->quark_notify_queue, NULL);
@ -178,8 +166,11 @@ g_object_notify_queue_add (GObject *object,
pspec = redirect;
/* we do the deduping in _thaw */
nqueue->pspecs = g_slist_prepend (nqueue->pspecs, pspec);
nqueue->n_pspecs++;
if (g_slist_find (nqueue->pspecs, pspec) == NULL)
{
nqueue->pspecs = g_slist_prepend (nqueue->pspecs, pspec);
nqueue->n_pspecs++;
}
G_UNLOCK(notify_lock);
}