luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 03:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

gfdonotificationbackend: hold a strong ref on backend

Browse Source 
This is to avoid race between dispose() being called on the
GFdoNotificationBackend instance, and any pending operations which are
still waiting on a D-Bus reply when it’s disposed.

(thx to Philip Withnall for pointing that out)

Signed-off-by: Arnaud Rebillout <elboulangero@gmail.com>
This commit is contained in:
Arnaud Rebillout 2018-06-14 11:21:11 +07:00
parent c26558c1b1
commit 5a73eef749
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gio/gfdonotificationbackend.c
View File

@ -67,6 +67,7 @@ freedesktop_notification_free (gpointer data)
{
FreedesktopNotification *n = data;
g_object_unref (n->backend);
g_free (n->id);
g_free (n->default_action);
if (n->default_action_target)
@ -83,7 +84,7 @@ freedesktop_notification_new (GFdoNotificationBackend *backend,
FreedesktopNotification *n;
n = g_slice_new0 (FreedesktopNotification);
n->backend = backend;
n->backend = g_object_ref (backend);
n->id = g_strdup (id);
n->notify_id = 0;
g_notification_get_default_action (notification,