luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-11 23:16:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

gobject: Remove initial goto to repeat unref operation

Browse Source
This commit is contained in:
Marco Trevisan (Treviño) 2022-11-29 21:50:30 +01:00
parent a89048c4f1
commit 65303537b0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gobject/gobject.c
View File

@ -3791,7 +3791,7 @@ g_object_unref (gpointer _object)
/* here we want to atomically do: if (ref_count>1) { ref_count--; return; } */
old_ref = g_atomic_int_get (&object->ref_count);
retry_atomic_decrement1:
if (old_ref > 1)
while (old_ref > 1)
{
/* valid if last 2 refs are owned by this call to unref and the toggle_ref */
gboolean has_toggle_ref = OBJECT_HAS_TOGGLE_REF (object);
@ -3799,15 +3799,17 @@ g_object_unref (gpointer _object)
if (!g_atomic_int_compare_and_exchange_full ((int *)&object->ref_count,
old_ref, old_ref - 1,
&old_ref))
goto retry_atomic_decrement1;
continue;
TRACE (GOBJECT_OBJECT_UNREF(object,G_TYPE_FROM_INSTANCE(object),old_ref));
/* if we went from 2->1 we need to notify toggle refs if any */
if (old_ref == 2 && has_toggle_ref) /* The last ref being held in this case is owned by the toggle_ref */
toggle_refs_notify (object, TRUE);
return;
}
else
{
GSList **weak_locations;
GObjectNotifyQueue *nqueue;