luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-13 07:56:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

gdbusconnection: Don't g_printerr() when exiting

Browse Source 
exit-on-close for a DBus connection is a completely normal thing.  On
a regular GNOME login, gdm retains the X server, but terminates the
session login bus and associated helpers like gnome-settings-dameon,
the a11y tools, etc.

I've seen several downstream reports of confusion as to what these
apparent error messages mean in the system log.  It doesn't help
that they're so obtuse.

We're also printing them to stderr, when this is not an error.

The reason this was introduced is presumably some people were confused
as to why their process exited when the system bus did.  But the
solution for that I believe is documentation, not printing stuff to
everyone's system log in normal operation.

https://bugzilla.gnome.org/show_bug.cgi?id=742386
This commit is contained in:
Colin Walters 2015-01-05 09:40:37 -05:00
parent 905e916573
commit 66bc9660c4
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gio/gdbusconnection.c
View File

@ -804,17 +804,6 @@ g_dbus_connection_real_closed (GDBusConnection *connection,
(flags & FLAG_INITIALIZED) != 0 &&
connection->initialization_error == NULL)
{
if (error != NULL)
{
g_printerr ("%s: Remote peer vanished with error: %s (%s, %d). Exiting.\n",
G_STRFUNC,
error->message,
g_quark_to_string (error->domain), error->code);
}
else
{
g_printerr ("%s: Remote peer vanished. Exiting.\n", G_STRFUNC);
}
raise (SIGTERM);
}
}