luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-11-03 17:48:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

gatomic: Mark pointer as (type gpointer)

Browse Source 
Otherwise, it appears as an "in" parameter with
  <type name="gint" c:type="volatile gint*"/>
which is very confusing to the bindings.

An alternative would be to mark it as an "inout" integer, which matches
the semantics somewhat. However, that wouldn't quite capture the concept
of the value being modified having (pointer) identity, which is of
utmost importance for atomic operations. Hence, just say that we accept
a pointer to the value.

Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
This commit is contained in:
Sergey Bugaev
2025-04-14 15:39:56 +03:00
parent 841b565b8d
commit 66db12c411
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
glib/gatomic.c
View File

@@ -57,7 +57,7 @@
/**
* g_atomic_int_get:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gconstpointer): a pointer to a #gint or #guint
*
* Gets the current value of @atomic.
*
@@ -79,7 +79,7 @@ gint
/**
* g_atomic_int_set:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @newval: a new value to store
*
* Sets the value of @atomic to @newval.
@@ -101,7 +101,7 @@ void
/**
* g_atomic_int_inc:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
*
* Increments the value of @atomic by 1.
*
@@ -122,7 +122,7 @@ void
/**
* g_atomic_int_dec_and_test:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
*
* Decrements the value of @atomic by 1.
*
@@ -146,7 +146,7 @@ gboolean
/**
* g_atomic_int_compare_and_exchange:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @oldval: the value to compare with
* @newval: the value to conditionally replace with
*
@@ -177,7 +177,7 @@ gboolean
/**
* g_atomic_int_compare_and_exchange_full:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @oldval: the value to compare with
* @newval: the value to conditionally replace with
* @preval: (out): the contents of @atomic before this operation
@@ -210,7 +210,7 @@ gboolean
/**
* g_atomic_int_exchange:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @newval: the value to replace with
*
* Sets the @atomic to @newval and returns the old value from @atomic.
@@ -235,7 +235,7 @@ gint
/**
* g_atomic_int_add:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @val: the value to add
*
* Atomically adds @val to the value of @atomic.
@@ -264,7 +264,7 @@ gint
/**
* g_atomic_int_and:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @val: the value to 'and'
*
* Performs an atomic bitwise 'and' of the value of @atomic and @val,
@@ -291,7 +291,7 @@ guint
/**
* g_atomic_int_or:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @val: the value to 'or'
*
* Performs an atomic bitwise 'or' of the value of @atomic and @val,
@@ -318,7 +318,7 @@ guint
/**
* g_atomic_int_xor:
* @atomic: a pointer to a #gint or #guint
* @atomic: (type gpointer): a pointer to a #gint or #guint
* @val: the value to 'xor'
*
* Performs an atomic bitwise 'xor' of the value of @atomic and @val,
@@ -1149,7 +1149,7 @@ guintptr
/**
* g_atomic_int_exchange_and_add:
* @atomic: a pointer to a #gint
* @atomic: (type gpointer): a pointer to a #gint
* @val: the value to add
*
* This function existed before g_atomic_int_add() returned the prior