luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-12 15:36:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove two accidentally-exported symbols

Browse Source 
This reverts commit 85976cf91d and
properly removes the offending symbols from gio.symbols.

These two private symbols were found to be exported during Colin's
recent work cleaning up function visibility (among other things).

They were never exposed in any header file and I am 100% certain that
they have never been used by anybody.  They were always private -- only
exposed on the library symbol list.

This change will cause ABI checking tools to complain that we have
removed functions, but the change is completely harmless for actual
applications.

https://bugzilla.gnome.org/show_bug.cgi?id=687441
This commit is contained in:
Ryan Lortie 2012-11-19 16:10:55 -05:00
parent 5272bc4d67
commit 824bc48adb
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gio/gio.symbols
View File

@ -1680,7 +1680,6 @@ g_menu_append
g_menu_append_item
g_menu_append_section
g_menu_append_submenu
g_menu_attribute_hash_iter_get_type
g_menu_attribute_iter_get_name
g_menu_attribute_iter_get_next
g_menu_attribute_iter_get_type
@ -1709,7 +1708,6 @@ g_menu_item_set_label
g_menu_item_set_link
g_menu_item_set_section
g_menu_item_set_submenu
g_menu_link_hash_iter_get_type
g_menu_link_iter_get_name
g_menu_link_iter_get_next
g_menu_link_iter_get_type

8
gio/gmenumodel.c
View File

@ -195,9 +195,7 @@ typedef struct
typedef GMenuLinkIterClass GMenuLinkHashIterClass;
/* Strictly speaking, this is (unintentionally) ABI now, but don't use it
* outside GIO. bgo#687441 */
GType g_menu_link_hash_iter_get_type (void);
static GType g_menu_link_hash_iter_get_type (void);
G_DEFINE_TYPE (GMenuLinkHashIter, g_menu_link_hash_iter, G_TYPE_MENU_LINK_ITER)
@ -253,9 +251,7 @@ typedef struct
typedef GMenuAttributeIterClass GMenuAttributeHashIterClass;
/* Strictly speaking, this is (unintentionally) ABI now, but don't use it
* outside GIO. bgo#687441 */
GType g_menu_attribute_hash_iter_get_type (void);
static GType g_menu_attribute_hash_iter_get_type (void);
G_DEFINE_TYPE (GMenuAttributeHashIter, g_menu_attribute_hash_iter, G_TYPE_MENU_ATTRIBUTE_ITER)