luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-11-23 10:49:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

glocalfile: Complain if faccessat sets an unusual error

Browse Source 
Many libc implementations seem to be incompatible with this
optimisation.

Printing an error when the error is either `EINVAL` or `EBADF` should
make it easier to identify any more problematic platforms.
This commit is contained in:
Colin Kinloch
2025-11-16 15:56:17 +00:00
parent 298fa45f90
commit 8f8e3a43d7
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gio/glocalfile.c
View File

@@ -1280,7 +1280,19 @@ g_local_file_query_exists (GFile *file,
{
GLocalFile *local = G_LOCAL_FILE (file);
return faccessat (0, local->filename, F_OK, AT_EACCESS | AT_SYMLINK_NOFOLLOW) == 0;
if (faccessat (0, local->filename, F_OK, AT_EACCESS | AT_SYMLINK_NOFOLLOW) == 0)
return TRUE;
if G_UNLIKELY (errno == EBADF)
{
g_critical ("g_local_file_query_exists: faccessat didn't accept supplied dirfd");
}
else if G_UNLIKELY (errno == EINVAL)
{
g_critical ("g_local_file_query_exists: faccessat doesn't support supplied flags");
}
return FALSE;
}
#endif