luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-03 09:46:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

gdb: Fix GHashTable pretty printer off-by-one error

Browse Source 
Commit 7678b107 seems to have left the GHashTable pretty printer with an
off-by-one error, skipping the first key it encounters and printing an
extra garbage key/value pair instead. This fixes that by moving an
increment to the end of a loop rather than the beginning.
This commit is contained in:
Philip Chimento 2019-11-05 14:28:41 -08:00
parent e83c8abd2f
commit 9042326ffc
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
glib/glib_gdb.py
View File

@ -124,7 +124,6 @@ class GHashPrinter:
self.value = None self.value = None
return v return v
while long(self.pos) < long(self.size): while long(self.pos) < long(self.size):
self.pos = self.pos + 1
if long (self.hashes[self.pos]) >= 2: if long (self.hashes[self.pos]) >= 2:
key = self.keys[self.pos] key = self.keys[self.pos]
val = self.values[self.pos] val = self.values[self.pos]
@ -135,8 +134,12 @@ class GHashPrinter:
# Queue value for next result # Queue value for next result
self.value = ('[%dv]'% (self.pos), val) self.value = ('[%dv]'% (self.pos), val)
# Return key # Increment pos and return key
return ('[%dk]'% (self.pos), key) key = ('[%dk]'% (self.pos), key)
self.pos += 1
return key
self.pos += 1
raise StopIteration raise StopIteration
__next__ = next __next__ = next