luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-05-29 17:00:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

We were returning junk memory here, because we didn't copy the value

Browse Source 
2001-04-19  Havoc Pennington  <hp@redhat.com>

	* gobject.c (g_object_get_valist): We were returning junk memory
	here, because we didn't copy the value (G_VALUE_NOCOPY_CONTENTS
	passed to G_VALUE_LCOPY) and then we freed the GValue immediately
	after. Removed G_VALUE_NOCOPY_CONTENTS from here; need a
	G_VALUE_STEAL_CONTENTS or the like if we want this optimization.
This commit is contained in:
Havoc Pennington 2001-04-19 21:48:21 +00:00 committed by Havoc Pennington
parent 7ee286440d
commit a786a9a020
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gobject/ChangeLog
View File

@ -1,3 +1,11 @@
2001-04-19 Havoc Pennington <hp@redhat.com>
* gobject.c (g_object_get_valist): We were returning junk memory
here, because we didn't copy the value (G_VALUE_NOCOPY_CONTENTS
passed to G_VALUE_LCOPY) and then we freed the GValue immediately
after. Removed G_VALUE_NOCOPY_CONTENTS from here; need a
G_VALUE_STEAL_CONTENTS or the like if we want this optimization.
Wed Apr 18 09:46:56 2001 Owen Taylor <otaylor@redhat.com> Wed Apr 18 09:46:56 2001 Owen Taylor <otaylor@redhat.com>
* gobject.c gsignal.c: Change C++ comments for FIXME's to * gobject.c gsignal.c: Change C++ comments for FIXME's to

2
gobject/gobject.c
View File

@ -983,7 +983,7 @@ g_object_get_valist (GObject *object,
object_get_property (object, pspec, &value); object_get_property (object, pspec, &value);
G_VALUE_LCOPY (&value, var_args, G_VALUE_NOCOPY_CONTENTS, &error); G_VALUE_LCOPY (&value, var_args, 0, &error);
if (error) if (error)
{ {
g_warning ("%s: %s", G_STRLOC, error); g_warning ("%s: %s", G_STRLOC, error);