luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-12 15:36:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Explicitly mark size parameter as (in)

Browse Source 
The generated gir file marks the size parameter as "out" by default. This is wrong in the context of a caller allocated buffer with a given size. Explicitly marking the size parameter as (in) fixes the issue.
This commit is contained in:
badcel 2023-04-11 20:40:00 +02:00
parent 718b5d5cd3
commit a89b72389a
No known key found for this signature in database
GPG Key ID: 70A8373EEB2233E0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gio/gsocket.c
View File

@ -3304,7 +3304,7 @@ g_socket_receive_with_timeout (GSocket *socket,
* @socket: a #GSocket
* @buffer: (array length=size) (element-type guint8) (out caller-allocates):
* a buffer to read data into (which should be at least @size bytes long).
* @size: the number of bytes you want to read from the socket
* @size: (in): the number of bytes you want to read from the socket
* @cancellable: (nullable): a %GCancellable or %NULL
* @error: #GError for error reporting, or %NULL to ignore.
*
@ -3354,7 +3354,7 @@ g_socket_receive (GSocket *socket,
* @socket: a #GSocket
* @buffer: (array length=size) (element-type guint8) (out caller-allocates):
* a buffer to read data into (which should be at least @size bytes long).
* @size: the number of bytes you want to read from the socket
* @size: (in): the number of bytes you want to read from the socket
* @blocking: whether to do blocking or non-blocking I/O
* @cancellable: (nullable): a %GCancellable or %NULL
* @error: #GError for error reporting, or %NULL to ignore.