luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-03 09:46:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

GObject: require READ or WRITE on property install

Browse Source 
g_object_class_install_property() currently lets you install properties
that are neither readable nor writable.  Add a check to prevent that.

https://bugzilla.gnome.org/show_bug.cgi?id=666616
This commit is contained in:
Ryan Lortie 2011-12-20 19:43:21 -05:00
parent 4e793c2eef
commit b237187109
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gobject/gobject.c
View File

@ -530,6 +530,7 @@ g_object_class_install_property (GObjectClass *class,
class->flags |= CLASS_HAS_PROPS_FLAG;
g_return_if_fail (pspec->flags & (G_PARAM_READABLE | G_PARAM_WRITABLE));
if (pspec->flags & G_PARAM_WRITABLE)
g_return_if_fail (class->set_property != NULL);
if (pspec->flags & G_PARAM_READABLE)

3
gobject/tests/param.c
View File

@ -687,9 +687,6 @@ static void test_implementation_class_init (TestImplementationClass *class)
if (perms[change_this_flag] == NULL)
g_error ("Interface property does not exist");
if (!(use_this_flag & (G_PARAM_READABLE | G_PARAM_WRITABLE)))
g_error ("g_object_class_install_property should probably fail here...");
g_snprintf (prop_name, sizeof prop_name, "%s-%s", names[change_this_type], perms[change_this_flag]);
pspec = g_param_spec_object (prop_name, prop_name, prop_name, types[use_this_type], use_this_flag);
g_object_class_install_property (class, 1, pspec);