luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-02 07:36:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't repeat a failed fclose() call, since that invokes undefined

Browse Source 
2006-04-26  Matthias Clasen  <mclasen@redhat.com>

	* glib/grand.c (g_rand_new): Don't repeat a failed fclose()
	call, since that invokes undefined behaviour.  (Coverity)
This commit is contained in:
Matthias Clasen 2006-04-26 04:19:48 +00:00 committed by Matthias Clasen
parent d4ac791e02
commit b8b28a7206
3 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
2006-04-26 Matthias Clasen <mclasen@redhat.com>
* glib/grand.c (g_rand_new): Don't repeat a failed fclose()
call, since that invokes undefined behaviour. (Coverity)
2006-04-25 Matthias Clasen <mclasen@redhat.com>
* glib/gbookmarkfile.c (is_element_full): Avoid a possible

5
ChangeLog.pre-2-12
View File

@ -1,3 +1,8 @@
2006-04-26 Matthias Clasen <mclasen@redhat.com>
* glib/grand.c (g_rand_new): Don't repeat a failed fclose()
call, since that invokes undefined behaviour. (Coverity)
2006-04-25 Matthias Clasen <mclasen@redhat.com>
* glib/gbookmarkfile.c (is_element_full): Avoid a possible

7
glib/grand.c
View File

@ -191,12 +191,7 @@ g_rand_new (void)
if (r != 1)
dev_urandom_exists = FALSE;
do
{
errno = 0;
fclose (dev_urandom);
}
while G_UNLIKELY (errno == EINTR);
fclose (dev_urandom);
}
else
dev_urandom_exists = FALSE;