luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-12-25 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

registrybackend: do not leak the watch data in case of failure

Browse Source
This commit is contained in:
Ignacio Casal Quinteiro 2016-01-26 13:15:51 +01:00
parent 9e805ffd43
commit bad7e4a114
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gio/gregistrysettingsbackend.c
View File

@ -1706,7 +1706,7 @@ watch_start (GRegistryBackend *self)
if (watch->message_sent_event == NULL || watch->message_received_event == NULL)
{
g_message_win32_error (0, "gregistrybackend: Failed to create sync objects.");
goto fail_1;
goto fail;
}
/* Use a small stack to make the thread more lightweight. */
@ -1714,20 +1714,22 @@ watch_start (GRegistryBackend *self)
if (watch->thread == NULL)
{
g_message_win32_error (0, "gregistrybackend: Failed to create notify watch thread.");
goto fail_2;
goto fail;
}
self->watch = watch;
return TRUE;
fail_2:
fail:
DeleteCriticalSection (watch->message_lock);
g_slice_free (CRITICAL_SECTION, watch->message_lock);
CloseHandle (watch->message_sent_event);
CloseHandle (watch->message_received_event);
fail_1:
if (watch->message_sent_event != NULL)
CloseHandle (watch->message_sent_event);
if (watch->message_received_event != NULL)
CloseHandle (watch->message_received_event);
g_slice_free (WatchThreadState, watch);
return FALSE;
}