luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-02-28 05:02:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

simpleproxyresolver: Don't crash on invalid hostname

Browse Source 
Check for g_hostname_to_ascii() failure, rather than crashing when
checking whether an invalid hostname should go through the proxy.

The HTTP library should report the error about the invalid hostname
once we actually try to connect to it.

https://bugzilla.gnome.org/show_bug.cgi?id=772989
This commit is contained in:
Bastien Nocera 2016-12-07 17:34:02 +01:00 committed by Philip Withnall
parent 1a99154898
commit cb8c919952
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gio/gsimpleproxyresolver.c
View File

@ -287,11 +287,13 @@ ignore_host (GSimpleProxyResolver *resolver,
if (priv->ignore_domains)
{
length = 0;
if (g_hostname_is_non_ascii (host))
host = ascii_host = g_hostname_to_ascii (host);
length = strlen (host);
if (host)
length = strlen (host);
for (i = 0; priv->ignore_domains[i].length; i++)
for (i = 0; length > 0 && priv->ignore_domains[i].length; i++)
{
GSimpleProxyResolverDomain *domain = &priv->ignore_domains[i];