luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-03-03 14:42:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests: Don’t spawn test processes via the terminal in the appinfo test

Browse Source 
There seems to be no reason to do so, and since the `appinfo` test was
ported to use `G_TEST_OPTION_ISOLATE_DIRS`, it has been causing
coredumps to accumulate. `gnome-terminal` was chosen as the terminal,
but it couldn’t find its GSettings schemas due to all the XDG
environment variables being cleared to `/dev/null` by
`G_TEST_OPTION_ISOLATE_DIRS`.

In order to keep using `gnome-terminal` as a subprocess in the tests,
we’d need to explicitly set up its environment so it can load the right
GSettings schemas. That’s a lot of work for not much gain.

Signed-off-by: Philip Withnall <withnall@endlessm.com>

Helps: #436
This commit is contained in:
Philip Withnall 2019-06-28 12:57:00 +01:00
parent 5e7c18fa48
commit d50caa8fb9
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gio/tests/appinfo-test.desktop.in
View File

@ -9,7 +9,7 @@ Comment=GAppInfo example
Comment[de]=GAppInfo Beispiel Comment[de]=GAppInfo Beispiel
Exec=@installed_tests_dir@/appinfo-test --option %U %i --name %c --filename %k %m %% Exec=@installed_tests_dir@/appinfo-test --option %U %i --name %c --filename %k %m %%
Icon=testicon.svg Icon=testicon.svg
Terminal=true Terminal=false
StartupNotify=true StartupNotify=true
StartupWMClass=appinfo-class StartupWMClass=appinfo-class
MimeType=image/png;image/jpeg; MimeType=image/png;image/jpeg;

2
gio/tests/appinfo.c
View File

@ -87,7 +87,7 @@ test_launch_no_app_id (void)
"Comment=GAppInfo example\n" "Comment=GAppInfo example\n"
"Comment[de]=GAppInfo Beispiel\n" "Comment[de]=GAppInfo Beispiel\n"
"Icon=testicon.svg\n" "Icon=testicon.svg\n"
"Terminal=true\n" "Terminal=false\n"
"StartupNotify=true\n" "StartupNotify=true\n"
"StartupWMClass=appinfo-class\n" "StartupWMClass=appinfo-class\n"
"MimeType=image/png;image/jpeg;\n" "MimeType=image/png;image/jpeg;\n"