Set an error in all failure cases. (#324332, Tim-Philipp Müller)

2005-12-17  Matthias Clasen  <mclasen@redhat.com>

        * glib/goption.c (parse_short_option): Set an error in all
        failure cases.  (#324332, Tim-Philipp Müller)
This commit is contained in:
Matthias Clasen 2005-12-18 02:46:27 +00:00 committed by Matthias Clasen
parent 78568970db
commit df21b345c5
4 changed files with 19 additions and 2 deletions

View File

@ -1,3 +1,8 @@
2005-12-17 Matthias Clasen <mclasen@redhat.com>
* glib/goption.c (parse_short_option): Set an error in all
failure cases. (#324332, Tim-Philipp Müller)
2005-12-17 Sebastian Wilhelmi <seppi@seppi.de>
* glib/gatomic.c: Fix memory barrier position in g_atomic_int_get

View File

@ -1,3 +1,8 @@
2005-12-17 Matthias Clasen <mclasen@redhat.com>
* glib/goption.c (parse_short_option): Set an error in all
failure cases. (#324332, Tim-Philipp Müller)
2005-12-17 Sebastian Wilhelmi <seppi@seppi.de>
* glib/gatomic.c: Fix memory barrier position in g_atomic_int_get

View File

@ -1,3 +1,8 @@
2005-12-17 Matthias Clasen <mclasen@redhat.com>
* glib/goption.c (parse_short_option): Set an error in all
failure cases. (#324332, Tim-Philipp Müller)
2005-12-17 Sebastian Wilhelmi <seppi@seppi.de>
* glib/gatomic.c: Fix memory barrier position in g_atomic_int_get

View File

@ -921,8 +921,10 @@ parse_short_option (GOptionContext *context,
{
if (*new_index > index)
{
g_warning ("FIXME: figure out the correct error here");
g_set_error (error,
G_OPTION_ERROR, G_OPTION_ERROR_FAILED,
_("Error parsing option %s"), option_name);
g_free (option_name);
return FALSE;
}