luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 03:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

tests: Assert there no errors first in gdbus-test-codegen

Browse Source 
Before checking the properties of `*_proxy`, assert that there were no
errors in constructing the proxy first. Otherwise the property checks
will crash on `NULL` pointer dereferences.

The test is still intermittently buggy somewhere, but at least this
commit will cause a relevant error message to be printed on failure.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
This commit is contained in:
Philip Withnall 2023-12-05 15:58:45 +00:00
parent c40fa821b8
commit e646c631b2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gio/tests/gdbus-test-codegen.c
View File

@ -1395,8 +1395,8 @@ check_proxies_in_thread (gpointer user_data)
"/bar",
NULL, /* GCancellable* */
&error);
check_bar_proxy (bar_proxy, thread_loop);
g_assert_no_error (error);
check_bar_proxy (bar_proxy, thread_loop);
g_object_unref (bar_proxy);
error = NULL;
@ -1406,8 +1406,8 @@ check_proxies_in_thread (gpointer user_data)
"/bat",
NULL, /* GCancellable* */
&error);
check_bat_proxy (bat_proxy, thread_loop);
g_assert_no_error (error);
check_bat_proxy (bat_proxy, thread_loop);
g_object_unref (bat_proxy);
error = NULL;
@ -1417,8 +1417,8 @@ check_proxies_in_thread (gpointer user_data)
"/authorize",
NULL, /* GCancellable* */
&error);
check_authorize_proxy (authorize_proxy, thread_loop);
g_assert_no_error (error);
check_authorize_proxy (authorize_proxy, thread_loop);
g_object_unref (authorize_proxy);
error = NULL;