GWin32AppInfo: Remove assertion on the opened registry key

Relax assertion about opened registry key as it may have been removed
in the meantime between enumeration and when opening, or (more likely)
we may not have the required permissions to open the some enumerated
keys (i.e. RegOpenKeyExW fails and returns ERROR_ACCESS_DENIED).

Fixes https://gitlab.com/inkscape/inbox/-/issues/5669
This commit is contained in:
Luca Bacci 2021-09-21 16:09:23 +02:00 committed by Philip Withnall
parent 2aca2cfbcc
commit eb3bcf8ba0

View File

@ -983,7 +983,10 @@ get_verbs (GWin32RegistryKey *program_id_key,
name,
NULL);
g_assert (subkey != NULL);
/* We may not have the required access rights to open the child key */
if (subkey == NULL)
continue;
/* The key we're looking at is "<some_root>/Shell/<this_key>",
* where "Shell" is verbshell_prefix.
* If it has a value named 'Subcommands' (doesn't matter what its data is),