luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2025-01-11 15:06:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix thread-safety

Browse Source 
The n_children variable can be written when locked, while the n_supers
variable is read at any time. As they both share the same bytes,
accessing them is not threadsafe.
This patch puts them into different bytes.

Thanks to Xan Lopez and valgrind for noticing this.
This commit is contained in:
Benjamin Otte 2009-11-20 16:47:09 +01:00
parent ba2b2bbca2
commit ec79146572
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gobject/gtype.c
View File

@ -223,13 +223,13 @@ typedef enum
struct _TypeNode
{
GTypePlugin *plugin;
guint n_children : 12;
guint n_children; /* writable with lock */
guint n_supers : 8;
guint _prot_n_ifaces_prerequisites : 9;
guint is_classed : 1;
guint is_instantiatable : 1;
guint mutatable_check_cache : 1; /* combines some common path checks */
GType *children;
GType *children; /* writable with lock */
TypeData * volatile data;
GQuark qname;
GData *global_gdata;