4271 Commits

Author SHA1 Message Date
Matthias Clasen
5951295937 fileutils: Improve test coverage
Add tests for corner cases of g_path_get_basename, and
for the errno-to-file-error conversion.
2012-04-08 10:24:51 -04:00
Matthias Clasen
550b69b963 sort: Improve test coverage
Test the code paths that sort 'large' items.
2012-04-08 10:24:51 -04:00
Matthias Clasen
06015064b8 date: Improve test coverage
Add tests that exercise g_date_order, g_date_compare, g_date_clamp,
and more of the date parsing functions.
2012-04-08 10:24:50 -04:00
Matthias Clasen
cbeecdc4ae convert: Improve test coverage
Add a test that excercises the 'no conversion' code path.
This uncovered that we don't treat errno properly in this path,
and as a consequence, the returned error code is unreliable.
2012-04-08 10:24:50 -04:00
Matthias Clasen
7d489acecc collate: Improve test coverage
Add some strings that exercise the non-ASCII parts of our
collation support.
2012-04-08 10:24:50 -04:00
Matthias Clasen
8db4b949b8 Always use '/' in test paths
It does not make much sense to use a platform-dependent
directory separator in these strings, since they are not
filesystem paths.

https://bugzilla.gnome.org/show_bug.cgi?id=673216
2012-04-06 20:52:15 -04:00
Dan Winship
a81a062202 gchecksum: fix strict-aliasing warnings in the MD5 code
https://bugzilla.gnome.org/show_bug.cgi?id=673191
2012-04-05 12:57:56 -04:00
Dieter Verfaillie
2655262889 Fix malformed GTK-Doc comment blocks: remove repeated comment blocks.
gio/gproxyresolver.h: GProxyResolver already documented in gio/giotypes.h
gio/gtlsbackend.h: GTlsBackend already documented in gio/gtlsbackend.c
gio/gtlsclientconnection.h: GTlsClientConnection already documented in gio/gtlsclientconnection.c
gio/gtlsconnection.h: GTlsConnection already documented in gio/gtlsconnection.c
gio/gunixconnection.h: GTcpConnection already documented in gio/giotypes.h
glib/gversion.h: GLIB_CHECK_VERSION already documented in glib/gversion.c

Found these thanks to the improved gobject-introspection
GTK-Doc comment block/annotation parser.
See https://bugzilla.gnome.org/show_bug.cgi?id=672254

https://bugzilla.gnome.org/show_bug.cgi?id=673385
2012-04-05 10:23:46 -03:00
Dieter Verfaillie
ce7f1a0789 Fix malformed GTK-Doc comment blocks: don't confuse GTK-Doc parsers.
Found these thanks to the improved gobject-introspection
GTK-Doc comment block/annotation parser.
See https://bugzilla.gnome.org/show_bug.cgi?id=672254

https://bugzilla.gnome.org/show_bug.cgi?id=673385
2012-04-05 10:23:45 -03:00
Dieter Verfaillie
0183c1f8a1 Fix malformed GTK-Doc comment blocks: invalid parameters and tags.
Found these thanks to the improved gobject-introspection
GTK-Doc comment block/annotation parser.
See https://bugzilla.gnome.org/show_bug.cgi?id=672254

https://bugzilla.gnome.org/show_bug.cgi?id=673385
2012-04-05 10:23:42 -03:00
Dieter Verfaillie
a058c1c13e Fix malformed GTK-Doc comment blocks: mutliline annotations are invalid.
Found these thanks to improved gobject-introspection GTK-Doc
comment block/annotation parser from:
https://bugzilla.gnome.org/show_bug.cgi?id=672254

https://bugzilla.gnome.org/show_bug.cgi?id=673385
2012-04-05 10:23:41 -03:00
Dieter Verfaillie
8e740f726f Fix malformed GTK-Doc comment blocks: add missing colons.
Found these thanks to improved gobject-introspection GTK-Doc
comment block/annotation parser from:
https://bugzilla.gnome.org/show_bug.cgi?id=672254

https://bugzilla.gnome.org/show_bug.cgi?id=673385
2012-04-05 10:23:39 -03:00
Matthias Clasen
588c2bacf7 Improve keyfile test coverage 2012-04-04 15:01:48 -04:00
Matthias Clasen
3eec7eeeaa Remove a bit of unused code
_g_utf8_strwidth is always called with max == -1, so remove the
parameter and update all callers.
2012-04-04 15:01:48 -04:00
Matthias Clasen
84a1b8aac8 Improve test coverage
Add tests for all the suffixes in g_format_size.
2012-04-04 15:01:48 -04:00
Dan Winship
51609ec943 tests/gdatetime: fix new_from_unix test
When creating a struct tm for "1990-01-01T00:00:00" to pass to
mktime(), we have to set tm_isdst to -1; leaving it set to 0 will
result in the wrong time being generated when run in a timezone where
January 1 would normally be tm_isdst==1 (ie, in southern hemisphere
DST-observing countries, like Australia).

https://bugzilla.gnome.org/show_bug.cgi?id=670254
2012-04-04 14:49:15 -04:00
Matthias Clasen
e51c3b4cfe Use new hashset api in the hash set tests 2012-04-02 09:09:11 -04:00
Matthias Clasen
e7c0f10ee0 Drop some unused PCRE sources
There is no point in compiling these, since we are not calling
any of the functions in them.
2012-04-01 23:08:42 -04:00
Antoine Jacoutot
829db4cec3 gthread-posix: fix typo in error message 2012-03-31 22:48:42 +02:00
Robert Ancell
4143842eb4 Add missing allow-none annotations for function parameters.
Found using:
find . -name '*.c' | xargs grep 'or %NULL' | grep ' \* @' | grep -v '@error' | grep -v allow-none
2012-03-31 20:34:28 +11:00
Bastien Nocera
9b0734a09c all: s/availible/available/ 2012-03-27 11:01:00 +02:00
Matthias Clasen
e927df7b7a Add a forgotten include guard
gbytes.h was missing the single-include guard.
2012-03-24 23:00:15 -04:00
Raphael Kubo da Costa
d2b7ee62f9 Make the `include' glib test case build on FreeBSD.
Defining _POSIX_C_SOURCE to 0 will make time.h not create the clockid_t
typedef used by some functions in pthread.h.

The right approach here is to set it to 199309L, which creates the
typedef on FreeBSD and doesn't set __USE_UNIX98 or __USE_XOPEN2K on
glibc, which is what the test is actually testing.

https://bugzilla.gnome.org/show_bug.cgi?id=672406
2012-03-22 11:02:07 -04:00
Chun-wei Fan
b08b301223 glib/gqsort.c: Fix C99ism/GCCism
-There were a number of variables that were declared in the middle of
 the block, so move these declarations to the start of the block
-There was a use of mempcpy, but it is a GCC extension, so use memcpy since
 we didn't care about the return value of the call to mempcpy.

https://bugzilla.gnome.org/show_bug.cgi?id=672095
2012-03-20 22:29:50 -04:00
Alexander Larsson
f23e7c3ef9 Fix the tests on win32
There was some unix-specific pathname handling in the test utils
which broke the css tests on win32.
2012-03-20 10:20:18 +01:00
Alexander Larsson
d0635dac52 Use g_unsetenv, not unsetenv
This fixed the win32 build
2012-03-20 10:19:42 +01:00
Matthias Clasen
2826ece6fc Fix distcheck
automake decided to complain about some more leftovers.
2012-03-19 16:58:48 -04:00
Matthias Clasen
6dfb50adf7 Don't return from a void function 2012-03-19 13:28:14 -04:00
Matthias Clasen
cb45176110 Fix a C99ism 2012-03-19 13:26:19 -04:00
Matthias Clasen
bd3063c742 Silence a compiler warning 2012-03-19 13:22:04 -04:00
Chun-wei Fan
bac0294c73 Update glibconfig.h.win32(.in)
Added the definitions below, as these #defines are needed for gqsort.c

#define ALIGNOF_GUINT32 4
#define ALIGNOF_GUINT64 8
#define ALIGNOF_UNSIGNED_LONG 4
2012-03-19 15:55:20 +08:00
Matthias Clasen
8c2434f01a Make inf testcase more forgiving
printf may produce "infinity" instead of "inf".

https://bugzilla.gnome.org/show_bug.cgi?id=668973
2012-03-17 23:43:52 -04:00
Sebastian Dröge
57878d6042 Use __builtin_bswap* for GUINT*_SWAP_LE_BE if building with GCC
https://bugzilla.gnome.org/show_bug.cgi?id=531901
2012-03-17 23:28:48 -04:00
Dieter Verfaillie
e2b47ae9e0 Fix out of tree build for MinGW/MSYS
When building with MinGW/MSYS with srcdir != builddir the build fails:
- to locate the generated .def files
- creating libglib-gdb.py
- creating libgobject-gdb.py

Solved this by explicitly instructing these files to be generated
in $(builddir)/...

https://bugzilla.gnome.org/show_bug.cgi?id=653167
2012-03-17 23:10:01 -04:00
Colin Walters
6833385c5a gmain: Use sig_atomic_t for list of pending Unix signals
Pointed out by: Simon McVittie <simon.mcvittie@collabora.co.uk>

https://bugzilla.gnome.org/show_bug.cgi?id=671997
2012-03-16 16:15:16 -04:00
David Benjamin
b0739f2223 Continue searching in PATH on ENODEV and ETIMEDOUT
Synchronize the error-handling logic from glibc. Users with networked
filesystems in their PATH may hit ETIMEDOUT.

https://bugzilla.gnome.org/show_bug.cgi?id=672201
2012-03-16 11:49:30 -04:00
Alexander Larsson
a43dd7435a Make g_array_sort* methods use a stable sort
Also, remove previous comments about sort stability in g_array_sort docs,
as the method that was explained does not work. Adds a new comment
about this.

https://bugzilla.gnome.org/show_bug.cgi?id=672095
2012-03-16 16:04:36 +01:00
Alexander Larsson
839957f275 Make g_qsort_with_data stable, based on glibc msort
We need a stable sort, and we might as well always use it rather
than have multiple sort versions. This picks up the glibc
merge sort implementation which it uses by default for qsort,
except we don't fall back to non-stable quicksort in some cases
like glibc

https://bugzilla.gnome.org/show_bug.cgi?id=672095
2012-03-16 16:04:36 +01:00
Ryan Lortie
fbbdf98668 g_log: mask log level before checking prefix flags
We check if the log level is in the "prefixed" list by checking it
against the g_log_msg_prefix bitfield.

Unfortunately we were failing to mask by G_LOG_LEVEL_MASK first, so if
the FATAL bit was set (for example) then it would never match.  This was
the case for g_error().

https://bugzilla.gnome.org/show_bug.cgi?id=672026
2012-03-13 20:15:21 -04:00
Ryan Lortie
545736c0fb glib-init: restore default for G_MESSAGES_PREFIXED
In the glib-init shuffle this ended up being set to no messages prefixed
by default.  Fix that so that we have prefixes back.

https://bugzilla.gnome.org/show_bug.cgi?id=672026
2012-03-13 20:15:21 -04:00
Ryan Lortie
063f03fa76 glib-init: fix obvious buffer size mismatch 2012-03-13 20:15:21 -04:00
Ryan Lortie
8084047ee3 logging test: unset G_MESSAGES_DEBUG
Having G_MESSAGES_DEBUG=all in the environment will fail this testcase.
2012-03-09 10:29:32 -05:00
Mark Janossy
265f265c67 deprecated threads: fix race in GStaticRecMutex
The very last access to the 'depth' field of GStaticRecMutex in
g_static_rec_mutex_unlock_full() was being performed after dropping the
implementation mutex for the last time.

This allowed the lock to be dropped an additional time if it was
acquired in another thread right at that instant (which is somewhat
likely, since another thread could have just been woken up by the lock
being released).

https://bugzilla.gnome.org/show_bug.cgi?id=670846
2012-03-09 09:54:23 -05:00
Alexander Larsson
3cf1ad1881 Use G_DEFINE_CONSTRUCTOR for the glib_init constructor
No need to hand-roll this when we have a macro version.
2012-03-05 15:06:22 +01:00
Matthias Clasen
c0c2cbe0ae Fix distcheck 2012-03-04 22:28:28 -05:00
Shota Akiyama
5f280eb6a8 glib/gmacros.h: Fix up attribute to avoid namespace collisions
https://bugzilla.gnome.org/show_bug.cgi?id=670751
2012-03-03 13:29:29 -05:00
Dan Winship
deea0e39ba gspawn: rename G_SPAWN_ERROR_2BIG to be more bindings-friendly
Rename G_SPAWN_ERROR_2BIG to G_SPAWN_ERROR_TOO_BIG (while keeping the
old name for compatibility), to fix problems with language bindings
where the old name translates into something that would be
syntactically invalid due to starting with a digit.

https://bugzilla.gnome.org/show_bug.cgi?id=671025
2012-03-03 13:26:43 -05:00
Jörn Magens
00f1e1f5c2 GSequence: add note about lookup requiring sorting
g_sequence_lookup() only works on sorted sequences, but it's quite easy
to create unsorted sequences.  Add a note to the documentation that the
sequence must be sorted in order for g_sequence_lookup() to work.

https://bugzilla.gnome.org/show_bug.cgi?id=670969
2012-03-02 09:08:30 -05:00
Colin Walters
80611295ab g_uri_unescape_segment: Mention (allow-none)/%NULL in documentation 2012-02-29 13:09:41 -05:00
Christian Persch
51f1297a6e Fixup docs comment 2012-02-27 16:25:50 +01:00