Commit Graph

596 Commits

Author SHA1 Message Date
Christoph Reiter
db90b3b3ae baseinfo: don't abort when calling g_base_info_get_name() on a GITypeInfo. Fixes #96
GITypeInfo is a GIBaseInfo so calling g_base_info_get_name() on it should do something
sensible.

g_base_info_get_name() has always been documented to return NULL in case no name
is available so return that instead.
2018-12-15 23:33:32 +00:00
Jasper St. Pierre
e01e11be42 giobjectinfo: Fix some documentation for find_vfunc_using_interfaces
See #66
2018-12-15 11:09:23 +01:00
Tomasz Miąsko
292afa1d58 docs: Field offsets are in the units of bytes 2018-12-14 16:28:58 +01:00
Christoph Reiter
5e8e1a761e docs: Remove everything not related to libgirepository and restructure. Fixes #244
The gtk-doc docs were including some bits of overal g-i docs but mostly unfinished
and outdated.

We now have the general docs in sphinx so remove the duplication and make the gtk-docs
just about the libgirepository API and nothing more.

This also renames some titles and fixes some missing links in the struct hierarchy
while at it.
2018-12-14 11:29:11 +01:00
Christoph Reiter
722518e5bc docs: fix gtk-doc warnings and update version infos
Move things around and rename things until gtk-doc is happy.

This also moves the "Since" annotations to the next stable releases and
adds version added info for g_callable_info_get_instance_ownership_transfer()
and g_struct_info_find_field().
2018-12-09 18:26:26 +01:00
Thibault Saunier
4b32b6e116 writer: Include documentation and symbol position in source files
Some documentation tool (as hotdoc[0]) need to have information about
symbol declaration and documentation positions in the source files
to be able to do smart indexing (automatically build the documenation
index).

[0] https://hotdoc.github.io/

Fixes #175
2018-11-28 09:29:07 -03:00
Christoph Reiter
8c36d53cba girnode: remove wrongly added g_assert_not_reached(). Fixes #218
Added in 9535fc48. After the switch it calls _g_ir_node_build_typelib() again
handling the other types.
2018-08-03 08:06:08 +02:00
Christoph Reiter
a060582afe girepository: port from g_type_class_add_private() to G_ADD_PRIVATE()
This lets us enable -Wdeprecated-declarations
2018-07-30 07:53:01 +02:00
Christoph Reiter
cff8329f70 build: enable -Wredundant-decls
The ffi decls were added in cbdd9ee09e367e4dd to work around broken
ffi headers. Let's assume this is fixed now.
2018-07-29 18:57:03 +02:00
Christoph Reiter
a718ebac86 build: enable -Wswitch-default
In case the surrounding code handles missing cases break, otherwise add
a g_assert_not_reached().

The generated parser code triggers this as well, so disable it there only.
2018-07-29 18:57:03 +02:00
Christoph Reiter
7be196f295 build: enable -Wtype-limits
hashv is unsigned, no need to check if >= 0
2018-07-29 18:57:03 +02:00
Christoph Reiter
f02e90f265 build: enable -Wimplicit-fallthrough
and fix a missplaced break
2018-07-29 18:57:03 +02:00
Christoph Reiter
3a5b0c2ae2 build: enable -Wshadow 2018-07-29 18:57:03 +02:00
Christoph Reiter
7cdf5d0d1d build: enable -Wcast-function-type
Where it's easy add dummy args to match the cast; where the target is a subset just
prevent the warning with a cast to void*.

Provide a real copy function for the boxed type code in regress_foo.
This code is never executed afaics, but why not.
2018-07-29 18:56:58 +02:00
Christoph Reiter
ee2ec3343e build: enable -Wsuggest-attribute=format
And use G_GNUC_PRINTF for the suggested function.
2018-07-29 16:50:19 +02:00
Christoph Reiter
573fe41788 build: enable -Wdouble-promotion 2018-07-29 16:49:53 +02:00
Christoph Reiter
9018e7b13c build: enable -Wincompatible-pointer-types 2018-07-29 16:49:23 +02:00
Christoph Reiter
16f2c2ad0b build: enable -Wdiscarded-qualifiers
Except for the Python module because nothing in the CPython API is marked const
and we'd have to cast everywhere.
2018-07-29 16:48:18 +02:00
Rico Tzschichholz
c704898e26 gdump: Fix print-format error while GFlagsValue->value is an unsigned int 2018-07-04 16:56:32 +02:00
Chun-wei Fan
4dafb4d5cf girepository: Properly acquire and check pointer values
On Windows (Visual Studio at least), unsigned longs are always 4 bytes,
on both 32-bit and x64 Windows, so we cannot use unsigned longs to deal
with pointers on 64-bit builds, as pointers are 8 bytes on 64-bit
Windows, which may well render the pointer (which we acquired from
libffi) invalid.

This will fix crashes in PyGObject which are manifested when launching
the cairo-demo example sript (intermittent) and when clicking on
"Interactive Dialog" button in the Dialog demo in the PyGObject GTK+
Code demos before entering anything in Entry 1 and Entry 2, when running
on x64 Visual Studio builds of the GTK+/PyGObject stack.

Also use size_t instead of unsigned long in gthash.c when we check that
memory & 0x3 is 0, to silence compiler warnings from enabling /Wp64,
which is used to detect portability problems on Visual Studio when
doing x86->x64 code builds.

https://bugzilla.gnome.org/show_bug.cgi?id=702788
2018-04-20 18:26:08 +02:00
Nirbheek Chauhan
c01bc6ef0e g-ir-scanner: Don't require SRCDIR and BUILDDIR env vars
When building with Meson, we cannot set environment variables while
running custom targets and our builddir layout is different from
Autotools anyway.

Now g-ir-scanner and friends can autodetect when they're being run
uninstalled by Meson and will find _giscanner.so and the giscanner
python files in the build directory. This is very similar to what
gdbus-codegen uses in glib/gio.

Same for girepository/gdump.c.
2018-03-10 19:05:19 +05:30
Nirbheek Chauhan
3a78885133 meson: Use glib_dep and configinc for girepository
glib_dep is what is actually needed to #include <glib.h>, not
gobject_dep. It works incidentally with system gobject/glib but not
when built via subprojects.
2018-03-10 19:05:19 +05:30
Patrick Griffis
4c8c1a53b8 Initial work on meson port 2018-03-10 19:05:19 +05:30
Emmanuele Bassi
caef88d094 docs: Mention GI_TYPELIB_PATH
The rules for searching typelib files should be properly documented,
as well as the way to modify the search paths.

https://bugzilla.gnome.org/show_bug.cgi?id=699328
2018-01-30 14:01:06 +00:00
Emmanuele Bassi
6b123c6cff Skip unused generic marshaller
You typically want to use the version in GObject, not this one.
2018-01-30 13:43:28 +00:00
Emmanuele Bassi
8d25dd4159 Remove unnecessary transfer annotation
Integers do not need a transfer annotation.
2018-01-30 13:41:15 +00:00
Leslie Giles
5ecbc70a05 Increase MAX_NAME_LEN
There is no real limit on the length of an identifier, and some
toolchains easily hit the current limit of 200 characters.

According to this answer on StackOverflow, 2048 seems to be the limit on
MSVC and ICC:

https://stackoverflow.com/questions/6007568/what-is-max-length-for-an-c-c-identifier-on-common-build-systems

So let's use that.

https://bugzilla.gnome.org/show_bug.cgi?id=764791
2017-12-19 18:51:39 +00:00
Patrick Griffis
ac76bbb53b girepository: Don't skip g_irepository_get_option_group()
This function works fine via introspection

https://bugzilla.gnome.org/show_bug.cgi?id=786665
2017-10-22 07:16:05 -04:00
Emmanuele Bassi
a6b5da2a4f Use locale-independent functions to parse numbers
https://bugzilla.gnome.org/show_bug.cgi?id=788087
2017-09-24 14:32:26 +01:00
Nicola Fontana
52727afbd2 docs: manifest typelib format portability
Apart the endianness of its scalar values the typelib binary format
must be considered arch-independent: make it clear in the docs.

https://bugzilla.gnome.org/show_bug.cgi?id=764116
2017-09-10 10:21:24 +02:00
Rico Tzschichholz
38068ab362 girepository: Annotate array and array-length parameter 2016-12-10 21:44:00 +01:00
Rico Tzschichholz
f3154d62a2 girepository: Annotate iterator arguments as (inout) 2016-09-15 10:27:27 +02:00
Tobias Mueller
79225a62c0 gthash: free cmph objects
If not done, it would leak the memory as address sanitizer reports:

==1294==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x7fa7a94b7602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x44c7a7 in __config_new girepository/cmph/cmph_structs.c:11
    #2 0x44aaa7 in cmph_config_new girepository/cmph/cmph.c:291
    #3 0x446fb5 in _gi_typelib_hash_builder_prepare girepository/gthash.c:114
    #4 0x406cf7 in add_directory_index_section girepository/girmodule.c:270
    #5 0x409ee6 in _g_ir_module_build_typelib girepository/girmodule.c:546
    #6 0x404ada in main tools/compiler.c:217
    #7 0x7fa7a70d482f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

==4091==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x7fc20c854602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x44a3f3 in cmph_io_vector_new girepository/cmph/cmph.c:228
    #2 0x44a965 in cmph_io_vector_adapter girepository/cmph/cmph.c:276
    #3 0x446f9f in _gi_typelib_hash_builder_prepare girepository/gthash.c:113
    #4 0x406cf7 in add_directory_index_section girepository/girmodule.c:270
    #5 0x409ee6 in _g_ir_module_build_typelib girepository/girmodule.c:546
    #6 0x404ada in main tools/compiler.c:217
    #7 0x7fc20a47182f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
2016-09-12 16:54:53 +02:00
Emmanuele Bassi
597d32df9c docs: Clarify return value documentation
Be a bit more specific than just saying "the transfer".
2016-05-18 23:12:13 +01:00
Emmanuele Bassi
f6ea169530 docs: Fix return value description
The return value of g_callable_info_get_caller_owns() is not a boolean
any more.
2016-05-18 23:10:46 +01:00
Paolo Borelli
50c7ae999c gdump: do not leak gfile objects 2016-05-08 15:35:13 -04:00
Carlos Garnacho
8a08674b33 girepository: Merge overrides with the regular search path
This reverts commit e81c4681cc88a00fcd841c5a68d860d3714b55d7

The GI_TYPELIB_PATH envvar will still allow overriding the default
typelib dir (based on gobject-introspection libdir), but applications
will have the last say about typelib lookup directories. The resulting
lookup order is now:

- Paths added through g_irepository_prepend_search_path()
- Paths in GI_TYPELIB_PATH
- The default gobject introspection lookup dir

This makes g_irespository_prepend_search_path() work as announced
despite environment variables. If any application was relying on
GI_TYPELIB_PATH overriding the paths of this function call (for e.g.
make check, or to be able to run code inside the project tree), it
is encouraged to set up a similar envvar for their application specific
lookup dir, or perform this override through other means.

https://bugzilla.gnome.org/show_bug.cgi?id=765735
2016-05-02 16:20:31 +02:00
Chun-wei Fan
b4df729c61 Fix code style
Make my last patch to this file conform to the code style in the rest
of this file.
2016-03-17 17:39:43 +08:00
Chun-wei Fan
4e43ed8112 cmph/bdz.c: Work Around MSVC 2012 x64 Compiler Bug
Due to an MSVC 2012 x64 compiler issue, the compiler generates bad code
for bdz.c, so the for loop in assign() continues running until the point
i falls below zero, causing an access violation when we try to do
curr_edge=queue[i]; (line 427 in bdz.c).  Address this issue by breaking
out of the loop at the end of it when i reaches 0 after doing the
necessary processing.

https://bugzilla.gnome.org/show_bug.cgi?id=733595
2016-03-16 22:48:18 +08:00
Philip Withnall
ec81889c35 girepository: Fix some memory leaks in gdump.c
These were leaking memory when dumping introspection data from projects
for building their GIR files. That’s generally not a problem, unless
you’re trying to build the project with -fsanitize=address, which causes
the GIR build phase to error out due to leaking memory.

https://bugzilla.gnome.org/show_bug.cgi?id=762653
2016-02-26 08:22:02 +00:00
Colin Walters
569b1dc9a8 Revert "libgirepository: Refuse to run in setuid applications"
This reverts commit 98bb6c91b710a95efe4cfeb303daeec3381b9c98.

It breaks programs simply executed *transitively* from a setuid
binary like the dbus daemon launch helper.

https://bugzilla.redhat.com/show_bug.cgi?id=1285991

Conflicts:
	girepository/girepository.c
2015-12-09 16:17:48 -05:00
Garrett Regier
6b55207f25 girepository: Fix memory leak in g_irepository_get_dependencies()
The transitive_dependencies GHashTable was being leaked.

https://bugzilla.gnome.org/show_bug.cgi?id=758448
2015-11-20 23:02:10 -08:00
Colin Walters
0f0b325d72 repository: Fix format string error in previous commit
Regression from df21d1f362a810f48a23b7c121bf09ce398539c7
2015-10-12 12:15:53 -04:00
Simon Feltman
220fbf35b8 girepository: Use constant time calculation for sections after Object fields
Add "n_field_callbacks" to ObjectBlob which represents the number of object
fields which are also callbacks. This a allows a constant time computation
for accessing sections after fields. Track writing of this field by passing
an extra argument through the girnode writers recursive call structure. This
essentally reverts a portion of commit 7027bb256d0d1ab which added a linear
time computation for accessing sections after fields.
Update typelib validator to also ensure n_field_callbacks is properly set.

https://bugzilla.gnome.org/show_bug.cgi?id=700338
2015-10-10 17:41:24 -04:00
Colin Walters
714414f0af girparser: Avoid a crash with an unset transfer annotation
Spotted by Coverity.

https://bugzilla.gnome.org/show_bug.cgi?id=752549
2015-10-04 12:00:23 -04:00
Colin Walters
3d2f1c2cd3 girepository: Drop executable bits from cmph .[ch] files
No reason for it.

https://bugzilla.gnome.org/show_bug.cgi?id=752931
2015-10-04 11:58:12 -04:00
Colin Walters
5bda8cc0d3 girepository: Add missing include
For previous commit.
2015-09-26 11:51:33 -04:00
Philip Withnall
ba2c4624da gitypeinfo: Expand documentation for g_type_info_is_pointer()
Note that (direction [in]out) parameters are only pointers if the
underlying type being transferred is a pointer, i.e. if the formal
parameter is a pointer to a pointer or deeper.

https://bugzilla.gnome.org/show_bug.cgi?id=720201
2015-09-26 11:37:15 -04:00
Colin Walters
02c64c25d2 libgirepository: Refuse to run in setuid applications
We know of at least one privilege escalation path via
`GI_TYPELIB_PATH`.  I don't want to audit for others.  If someone
shows up with a use case we can talk.

https://bugzilla.gnome.org/show_bug.cgi?id=755472
2015-09-24 11:10:36 -04:00
Jasper St. Pierre
3fa183524e girepository: Remove "optimization" for found prefixes
This optimization is bugged and broken in the case of certain
libraries. GNOME uses a lot of prefixes with "G", so we'll almost always
have found the prefix.

This is specifically a problem for something like GXml.xDocument, which
uses a type name starting with a lower-case letter, which fools the
prefix logic, but we're also fooled by the "G" appearing in GLib and
Gio.

A more sophisticated version of this check would have three passes:
check prefix with type-case, check prefix without type-case, global
search, but this is an edge case and it doesn't feel worth it to write.
2015-07-27 17:21:05 -07:00