1312ec6d0b
It seems bad style, to use a naive realloc() +1 increment each time a new element gets added. Instead, remember the allocation size and double the buffer size on buffer grow. This way we get linear amortized runtime complexity for buffer growth. Well, WeakRefStack uses a flat array for tracking the entires. We anyway need to search and memmove() the entries and are thus O(n) anyway. We do that, because it allows for relatively simple code while being memory efficient. Also, we do expect only a reasonably small number of weak notifications in the first place. I still think it makes sense to avoid the O(n) number of realloc() calls on top of that. Note that we do this while holding the (per-object) lock. It's one thing to do a linear search or a memmove(). It's another to do a (more expensive) realloc(). Also, shrink the buffer during g_object_weak_unref() to get rid of excess memory. Also, note that the initial allocation only allocates space for the first item. I think that makes sense, because I expect that many objects will only get a single weak notification registered. So this allocation should not yet have excess memory allocated. Also, note that the "flexible" array member WeakRefStack.weak_refs has a length of 1. Maybe we should use C99 flexible array members ([]) or the pre-C99 workaround ([0]). Anyway. Previously, we would always allocate space for that extra one tuple, but never use it. Fix that too.
GLib
GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.
The official download locations are: https://download.gnome.org/sources/glib
The official web site is: https://www.gtk.org/
Installation
See the file ‘INSTALL.md’. There is separate and more in-depth documentation for building GLib on Windows.
Supported versions
Upstream GLib only supports the most recent stable release series, the previous stable release series, and the current development release series. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.
See SECURITY.md for more details.
Documentation
API documentation is available online for GLib for the:
Discussion
If you have a question about how to use GLib, seek help on GNOME’s Discourse
instance. Alternatively, ask a question
on StackOverflow and tag it glib.
Reporting bugs
Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.
Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.
In bug reports please include:
- Information about your system. For instance:
- What operating system and version
- For Linux, what version of the C library
- And anything else you think is relevant.
- How to reproduce the bug.
- If you can reproduce it with one of the test programs that are built
in the
tests/subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
- If you can reproduce it with one of the test programs that are built
in the
- If the bug was a crash, the exact text that was printed out when the crash occurred.
- Further information such as stack traces may be useful, but is not necessary.
Contributing to GLib
Please follow the contribution guide to know how to start contributing to GLib.
Patches should be submitted as merge requests to gitlab.gnome.org. Note that you will need to be logged in to the site to use this page. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):
Closes: #123
Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.