3ade8a93f3
During g_datalist_id_update_atomic(), we get "data" and "destroy_notify" pointers. The callback can then create, update or steal the data. It steals it by setting the `*data` to NULL. In that case, the "destroy_notify" has no more significance, because the old data was stolen (and won't be touched by g_datalist_id_update_atomic()) and the new data that we return is NULL (which means there is no data at all, and nothing to destroy). Still, to be clearer about that, clear the "destroy_notify" to NULL at a few places, where we steal the data. Note that there are other g_datalist_id_update_atomic() places that also steal the data but still don't reset the "destroy_notify". Those places are about the quark_closure_array (CArray) and quark_weak_notifies (WeakRefStack). For those keys, we never set any "destroy_notify". We relay on the fact that we take care of the data explicitly and we never set it. We also don't double check that it's really set to NULL, when we rightly expect it to be NULL already. At those places, it feels wrong to suddenly reset "destroy_notify" to NULL. This is different from the places where this patch clears the "destroy_notify". At those places, we (sometimes) do have a callback set, and it might be clearer to explicitly clear it.
GLib
GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.
The official download locations are: https://download.gnome.org/sources/glib
The official web site is: https://www.gtk.org/
Installation
See the file ‘INSTALL.md’. There is separate and more in-depth documentation for building GLib on Windows.
Supported versions
Upstream GLib only supports the most recent stable release series, the previous stable release series, and the current development release series. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.
See SECURITY.md for more details.
Documentation
API documentation is available online for GLib for the:
Discussion
If you have a question about how to use GLib, seek help on GNOME’s Discourse
instance. Alternatively, ask a question
on StackOverflow and tag it glib.
Reporting bugs
Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.
Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.
In bug reports please include:
- Information about your system. For instance:
- What operating system and version
- For Linux, what version of the C library
- And anything else you think is relevant.
- How to reproduce the bug.
- If you can reproduce it with one of the test programs that are built
in the
tests/subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
- If you can reproduce it with one of the test programs that are built
in the
- If the bug was a crash, the exact text that was printed out when the crash occurred.
- Further information such as stack traces may be useful, but is not necessary.
Contributing to GLib
Please follow the contribution guide to know how to start contributing to GLib.
Patches should be submitted as merge requests to gitlab.gnome.org. Note that you will need to be logged in to the site to use this page. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):
Closes: #123
Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.