Philip Withnall e2639ce56e gsocketclient: Fix passing NULL to g_task_get_cancellable() ...

Fix a regression from commit abddb42d14, where it could pass `NULL` to
`g_task_get_cancellable()`, triggering a critical warning. This could
happen because the lifetime of `data->task` is not as long as the
lifetime of the `ConnectionAttempt`, but the code assumed it was.

Fix the problem by keeping a strong ref to that `GCancellable` around
until the `ConnectionAttempt` is finished being destroyed.

Signed-off-by: Philip Withnall <pwithnall@endlessos.org>

Fixes: #2687

2022-07-12 16:07:23 +01:00

76 KiB

Raw Blame History

View Raw