luc14n0/glib
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/glib.git synced 2024-11-10 03:16:17 +01:00
Code Issues Packages Projects Releases Wiki Activity
Low-level core library that forms the basis for projects such as GTK+ and GNOME.
30,674 Commits 296 Branches 577 Tags 135 MiB
C 95.3%
Python 2.4%
Meson 1.3%
Objective-C 0.3%
Shell 0.2%
Other 0.5%
aec5785e7b
Go to file
Philip Withnall aec5785e7b
gthread: Move thread _impl functions to static inlines for speed 
The changes made in commit bc59e28bf6
(issue #3399) fixed introspection of the GThread API. However, they
introduced a trampoline in every threading function. So with those
changes applied, the disassembly of `g_mutex_lock()` (for example) was:
```
0x7ffff7f038b0 <g_mutex_lock>    jmp 0x7ffff7f2f440 <g_mutex_lock_impl>
0x7ffff7f038b5                   data16 cs nopw 0x0(%rax,%rax,1)
```

i.e. It jumps straight to the `_impl` function, even with an optimised
build. Since `g_mutex_lock()` (and various other GThread functions) are
frequently run hot paths, this additional `jmp` to a function which has
ended up in a different code page is a slowdown which we’d rather avoid.

So, this commit reworks things to define all the `_impl` functions as
`G_ALWAYS_INLINE static inline` (which typically expands to
`__attribute__((__always_inline__)) static inline`), and to move them
into the same compilation unit as `gthread.c` so that they can be
inlined without the need for link-time optimisation to be enabled.

It makes the code a little less readable, but not much worse than what
commit bc59e28bf6 already did. And perhaps
the addition of the `inline` decorations to all the `_impl` functions
will make it a bit clearer what their intended purpose is
(platform-specific implementations).

After applying this commit, the disassembly of `g_mutex_lock()`
successfully contains the inlining for me:
```
=> 0x00007ffff7f03d80 <+0>:	xor    %eax,%eax
   0x00007ffff7f03d82 <+2>:	mov    $0x1,%edx
   0x00007ffff7f03d87 <+7>:	lock cmpxchg %edx,(%rdi)
   0x00007ffff7f03d8b <+11>:	jne    0x7ffff7f03d8e <g_mutex_lock+14>
   0x00007ffff7f03d8d <+13>:	ret
   0x00007ffff7f03d8e <+14>:	jmp    0x7ffff7f03610 <g_mutex_lock_slowpath>
```

I considered making a similar change to the other APIs touched in #3399
(GContentType, GAppInfo, GSpawn), but they are all much less performance
critical, so it’s probably not worth making their code more complex for
that sake.

Signed-off-by: Philip Withnall <pwithnall@gnome.org>

Fixes: #3417
2024-08-25 21:56:14 +01:00
.gitlab-ci CI/msys2-mingw32: Set G_DEBUGGER environment variable 2024-08-23 15:41:34 +02:00
.reuse reuse: License all .gitignore files as CC0-1.0 (public domain) 2024-04-17 15:32:42 +01:00
docs docs: Clarify distinction between GDrive, GVolume and GMount 2024-08-15 11:32:37 +01:00
fuzzing gthreadedresolver: Move private testing symbols to a private header 2024-02-09 10:05:56 +00:00
gio gmenumodel: Acknowledge in docs that the UI used in the example is old 2024-08-25 15:34:32 +01:00
girepository introspection: Correct GIO-Windows pkg-config name 2024-07-17 16:28:34 +08:00
glib gthread: Move thread _impl functions to static inlines for speed 2024-08-25 21:56:14 +01:00
gmodule tests: Run GModule tests in subprocesses 2024-07-24 17:07:23 +02:00
gobject gobjectnotifyqueue: Add G_GNUC_UNUSED in unused parameters 2024-08-13 04:40:11 +02:00
gthread docs: spelling and grammar fixes 2024-04-01 11:01:06 +00:00
LICENSES girepository: Add remaining license/copyright SPDX headers 2023-10-25 17:12:25 +01:00
m4macros m4macros: drop unused m4 files 2023-07-30 17:03:07 +04:00
po Merge branch 'translation' into 'main' 2024-08-25 14:31:03 +00:00
subprojects docs: Add initial support for using gi-docgen for docs 2023-10-11 14:01:28 +01:00
tests tests: Update the reuse lint limits 2024-04-17 15:47:02 +01:00
tools tools/glib.supp: Ignore valgrind false-positive error on wcsxfrm 2024-08-02 13:57:29 +02:00
.clang-format CI: Code check formating in CI 2019-11-21 14:03:01 -06:00
.dir-locals.el Add .dir-locals.el to tell Emacs users not to use tabs for C 2012-07-30 04:09:08 -04:00
.editorconfig docs: Add .editorconfig file 2021-10-28 14:47:53 +01:00
.gitignore docs: Move INSTALL.in to INSTALL.md 2022-05-11 13:02:49 +01:00
.gitlab-ci.yml CI/msys2-mingw32: Set G_DEBUGGER environment variable 2024-08-23 15:41:34 +02:00
.gitmodules ci: Update git paths to reflect new GitLab URI 2022-11-02 16:49:51 +00:00
.lcovrc ci: Also compile C++ files with coverage collection 2024-08-02 13:57:29 +02:00
CODE_OF_CONDUCT.md docs: Update Code of Conduct URI 2024-04-12 20:36:29 +01:00
CONTRIBUTING.md ci: Use meson compile rather than bare ninja 2023-08-16 13:07:05 +01:00
COPYING docs: Add all used licenses in a REUSE-compatible directory 2022-05-17 17:23:34 +01:00
glib.doap doap: Remove invalid maintainer entry 2024-08-12 11:46:22 +00:00
INSTALL.md docs: Document issue and merge request triaging and review guidelines 2023-06-29 16:50:00 +01:00
meson.build build: Check for epoll_create1 rather than epoll_create in meson.build 2024-08-25 15:28:21 +01:00
meson.options build: Rename meson_options.txt to meson.options 2024-06-13 04:50:04 -05:00
NEWS 2.81.2 2024-08-16 19:37:20 +01:00
README.md Expand security policy to cover previous stable branch 2023-10-03 09:12:37 +01:00
SECURITY.md Expand security policy to cover previous stable branch 2023-10-03 09:12:37 +01:00

README.md

GLib

GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.

The official download locations are: https://download.gnome.org/sources/glib

The official web site is: https://www.gtk.org/

Installation

See the file ‘INSTALL.md’. There is separate and more in-depth documentation for building GLib on Windows.

Supported versions

Upstream GLib only supports the most recent stable release series, the previous stable release series, and the current development release series. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.

See SECURITY.md for more details.

Documentation

API documentation is available online for GLib for the:

Discussion

If you have a question about how to use GLib, seek help on GNOME’s Discourse instance. Alternatively, ask a question on StackOverflow and tag it glib.

Reporting bugs

Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.

Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.

In bug reports please include:

  • Information about your system. For instance:
    • What operating system and version
    • For Linux, what version of the C library
    • And anything else you think is relevant.
  • How to reproduce the bug.
    • If you can reproduce it with one of the test programs that are built in the tests/ subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
  • If the bug was a crash, the exact text that was printed out when the crash occurred.
  • Further information such as stack traces may be useful, but is not necessary.

Contributing to GLib

Please follow the contribution guide to know how to start contributing to GLib.

Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):

Closes: #123

Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.