cecbb25eeb
GChildWatchSource uses waitpid(), among pidfd and GetExitCodeProcess(). It thus only works for child processes which the user must ensure to exist and not being reaped yet. Also, the user must not kill() the PID after the child process is reaped and must not race kill() against waitpid(). Also, the user must not call waitpid()/kill() after the child process is reaped. Previously, GChildWatchSource would call waitpid() already when adding the source (g_child_watch_source_new()) and from the worker thread (dispatch_unix_signals_unlocked()). That is racy: - if a child watcher is attached and did not yet fire, you cannot call kill() on the PID without racing against the PID being reaped on the worker thread. That would then lead to ESRCH or even worse, killing the wrong process. - if you g_source_destroy() the source that didn't fire yet, the user doesn't know whether the PID was reaped in the background. Any subsequent kill()/waitpid() may fail with ESRCH/ECHILD or even address the wrong process. The race is most visible on Unix without pidfd support, because then the process gets reaped on the worker thread or during g_child_watch_source_new(). But it's also with Windows and pidfd, because we would have waited for the process in g_child_watch_check(), where other callbacks could fire between reaping the process status and emitting the source's callback. Fix all that by calling waitpid() right before dispatching the callback. |
||
|---|---|---|
| .gitlab-ci | ||
| .reuse | ||
| docs | ||
| fuzzing | ||
| gio | ||
| glib | ||
| gmodule | ||
| gobject | ||
| gthread | ||
| LICENSES | ||
| m4macros | ||
| po | ||
| subprojects | ||
| tests | ||
| tools | ||
| .clang-format | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| .lcovrc | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| glib.doap | ||
| INSTALL.md | ||
| meson_options.txt | ||
| meson.build | ||
| NEWS | ||
| README.md | ||
| README.win32.md | ||
| SECURITY.md | ||
GLib
GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.
The official download locations are: https://download.gnome.org/sources/glib
The official web site is: https://www.gtk.org/
Installation
See the file 'INSTALL.md'
Supported versions
Only the most recent unstable and stable release series are supported. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.
See SECURITY.md for more details.
Documentation
API documentation is available online for GLib for the:
Discussion
If you have a question about how to use GLib, seek help on GNOME’s Discourse
instance. Alternatively, ask a question
on StackOverflow and tag it glib.
Reporting bugs
Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.
Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.
In bug reports please include:
- Information about your system. For instance:
- What operating system and version
- For Linux, what version of the C library
- And anything else you think is relevant.
- How to reproduce the bug.
- If you can reproduce it with one of the test programs that are built
in the
tests/subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
- If you can reproduce it with one of the test programs that are built
in the
- If the bug was a crash, the exact text that was printed out when the crash occurred.
- Further information such as stack traces may be useful, but is not necessary.
Contributing to GLib
Please follow the contribution guide to know how to start contributing to GLib.
Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):
Closes: #123
Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.