f6cf2bcfd2
GHashTable optimizes for the "set" case, where key and value are the same. See g_hash_table_add(). A user cannot see from outside, whether a GHashTable internally is a set and shares the keys and values array. Adding one key/value pair with differing key and value, will expand the GHashTable. In all other cases, the GHashTable API hides this implementation detail correctly. Except with g_hash_table_steal_extended(), when stealing both the key and the value. Fix that. This bug fix is obviously a change in behavior. In practice, it's unlikely that somebody would notice, because GHashTable contains opaque pointers and the user must know what the keys/values are and be aware of their ownership semantics when stealing them. That means, the change in behavior only affects instances that are internally a set, of what the user most likely is aware and fills the table with g_hash_table_add(). Such a user would not steal both the key and values at the same time. Even if they do, then previously stealing the value was pointless and would not give them what they wanted. It would not have meaningfully worked, and since nobody reported a bug about this yet, it's unlikely somebody noticed. The more problematic case when the user exhibits the bug is when the dictionary is unexpected a set internally. Imagine a mapping from numbers to numbers (e.g. a permutation). If "unexpectedly" the dictionary contains the identity permutation, steal-extended gives always NULL for the target number. The example is far fetched. In practice, it's unlikely that somebody is gonna notice either way. That is not an argument for fixing anything. The argument for fixing this, is that the bug breaks the illusion that the set is only an internal optimization. That is ugly and inconsistent. |
||
|---|---|---|
| .gitlab-ci | ||
| .reuse | ||
| docs | ||
| fuzzing | ||
| gio | ||
| girepository | ||
| glib | ||
| gmodule | ||
| gobject | ||
| gthread | ||
| LICENSES | ||
| m4macros | ||
| po | ||
| subprojects | ||
| tests | ||
| tools | ||
| .clang-format | ||
| .dir-locals.el | ||
| .editorconfig | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| .lcovrc | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| glib.doap | ||
| INSTALL.md | ||
| meson.build | ||
| meson.options | ||
| NEWS | ||
| README.md | ||
| SECURITY.md | ||
GLib
GLib is the low-level core library that forms the basis for projects such as GTK and GNOME. It provides data structure handling for C, portability wrappers, and interfaces for such runtime functionality as an event loop, threads, dynamic loading, and an object system.
The official download locations are: https://download.gnome.org/sources/glib
The official web site is: https://www.gtk.org/
Installation
See the file ‘INSTALL.md’. There is separate and more in-depth documentation for building GLib on Windows.
Supported versions
Upstream GLib only supports the most recent stable release series, the previous stable release series, and the current development release series. All older versions are not supported upstream and may contain bugs, some of which may be exploitable security vulnerabilities.
See SECURITY.md for more details.
Documentation
API documentation is available online for GLib for the:
Discussion
If you have a question about how to use GLib, seek help on GNOME’s Discourse
instance. Alternatively, ask a question
on StackOverflow and tag it glib.
Reporting bugs
Bugs should be reported to the GNOME issue tracking system. You will need to create an account for yourself. You may also submit bugs by e-mail (without an account) by e-mailing incoming+gnome-glib-658-issue-@gitlab.gnome.org, but this will give you a degraded experience.
Bugs are for reporting problems in GLib itself, not for asking questions about how to use it. To ask questions, use one of our discussion forums.
In bug reports please include:
- Information about your system. For instance:
- What operating system and version
- For Linux, what version of the C library
- And anything else you think is relevant.
- How to reproduce the bug.
- If you can reproduce it with one of the test programs that are built
in the
tests/subdirectory, that will be most convenient. Otherwise, please include a short test program that exhibits the behavior. As a last resort, you can also provide a pointer to a larger piece of software that can be downloaded.
- If you can reproduce it with one of the test programs that are built
in the
- If the bug was a crash, the exact text that was printed out when the crash occurred.
- Further information such as stack traces may be useful, but is not necessary.
Contributing to GLib
Please follow the contribution guide to know how to start contributing to GLib.
Patches should be submitted as merge requests to gitlab.gnome.org. If the patch fixes an existing issue, please refer to the issue in your commit message with the following notation (for issue 123):
Closes: #123
Otherwise, create a new merge request that introduces the change. Filing a separate issue is not required.