mingw/mingw64-headers
SHA256
6
0
Fork 2
forked from pool/mingw64-headers
Code Pull Requests Activity

Add support to use a different crt (boo#1243096) #2

Merged
jengelh merged 1 commits from rhabacker/mingw64-headers:master into master 2025-06-04 13:18:17 +02:00
Conversation 10 Commits 1 Files Changed 2 +11 -1
rhabacker commented 2025-05-12 22:42:11 +02:00
Owner
Copy Link
No description provided.
rhabacker added 1 commit 2025-05-12 22:42:12 +02:00
- Use UCRT on openSUSE Leap 16 by default (boo#1243096) d34fb76baa
jengelh reviewed 2025-05-13 01:27:15 +02:00
mingw64-headers.spec Outdated
@@ -19,3 +19,3 @@
Name: mingw64-headers
Version: 12.0.0
Release: 0
Release: 1
jengelh commented 2025-05-13 01:27:15 +02:00
Owner
Copy Link

This is useless and reset by OBS anyway.

This is useless and reset by OBS anyway.
rhabacker marked this conversation as resolved
jengelh reviewed 2025-05-13 01:27:26 +02:00
mingw64-headers.spec Outdated
@@ -56,2 +56,3 @@
%build
%_mingw64_configure --enable-sdk=all --with-default-msvcrt=msvcrt
%_mingw64_configure --enable-sdk=all \
%if 0%{suse_version} == 1600
jengelh commented 2025-05-13 01:27:26 +02:00
Owner
Copy Link

>=

`>=`
rhabacker commented 2025-05-13 04:58:33 +02:00
Author
Owner
Copy Link

This would set UCRT to Tumbleweed as the default for all packages. Can there be problems with the mingwxx-binutils, mingwxx-gcc or other package, because maybe something needs to be adjusted there as well? 16.0 is still a work in progress, so we can't break anything there. I would postpone this until later.

This would set UCRT to Tumbleweed as the default for all packages. Can there be problems with the mingwxx-binutils, mingwxx-gcc or other package, because maybe something needs to be adjusted there as well? 16.0 is still a work in progress, so we can't break anything there. I would postpone this until later.
jengelh commented 2025-05-14 09:10:30 +02:00
Owner
Copy Link

If it's not good enough for Tumbleweed, it isn't good enough for Leap16.

If it's not good enough for Tumbleweed, it isn't good enough for Leap16.
rhabacker marked this conversation as resolved
rhabacker force-pushed master from d34fb76baa to 3fd2ed5406 2025-05-13 05:03:11 +02:00 Compare
rhabacker force-pushed master from 3fd2ed5406 to 441669697a 2025-05-14 08:41:41 +02:00 Compare
michals commented 2025-05-14 11:22:41 +02:00
First-time contributor
Copy Link

Why the convoluted check, why not use the new headers from 16.0 on?

Also you need https://build.opensuse.org/request/show/1277215 or similar for this to work.

Why the convoluted check, why not use the new headers from 16.0 on? Also you need https://build.opensuse.org/request/show/1277215 or similar for this to work.
rhabacker commented 2025-05-14 12:59:21 +02:00
Author
Owner
Copy Link

Based on past experience, I am somewhat conservative here, as I cannot currently estimate what problems this elementary change will cause with the existing 600 packages and thus what additional work will be required for analysis and correction. I would first create an integration branch and use it to test the compiler, binutils and other important packages before rolling this out. The 16.0 repo is still new and not productive and can therefore be understood as such.

Also you need https://build.opensuse.org/request/show/1277215 or similar for this to work.

I would first activate this package on Leap 16.0 only.

Based on past experience, I am somewhat conservative here, as I cannot currently estimate what problems this elementary change will cause with the existing 600 packages and thus what additional work will be required for analysis and correction. I would first create an integration branch and use it to test the compiler, binutils and other important packages before rolling this out. The 16.0 repo is still new and not productive and can therefore be understood as such. > Also you need https://build.opensuse.org/request/show/1277215 or similar for this to work. I would first activate this package on Leap 16.0 only.
jengelh commented 2025-05-14 15:36:48 +02:00
Owner
Copy Link

It is a devel project. It is meant to be used for devel. You can always add something to prjconf like

%if "%_repository" == "openSUSE_Factory"
%define mingw_crt UCRT
%endif

and then evalute that in specfiles.
(Note the difference between openSUSE_Tumbleweed and openSUSE_Factory)

It is a devel project. It is meant to be used for devel. You can always add something to prjconf like ``` %if "%_repository" == "openSUSE_Factory" %define mingw_crt UCRT %endif ``` and then evalute that in specfiles. (Note the difference between openSUSE_Tumbleweed and openSUSE_Factory)
rhabacker commented 2025-05-15 12:12:07 +02:00
Author
Owner
Copy Link

I would first create an integration branch

On result from using the integration branch is that the changes for the mingxww-filesystem packages (https://build.opensuse.org/requests/1277215, https://build.opensuse.org/requests/1277677) must be applied before to avoid massive unresolved build failures.

> I would first create an integration branch On result from using the integration branch is that the changes for the mingxww-filesystem packages (https://build.opensuse.org/requests/1277215, https://build.opensuse.org/requests/1277677) must be applied before to avoid massive unresolved build failures.
rhabacker force-pushed master from 441669697a to e96b766f05 2025-05-16 10:30:07 +02:00 Compare
rhabacker force-pushed master from e96b766f05 to 6fc2bce094 2025-05-16 10:52:37 +02:00 Compare
rhabacker changed title from - Use UCRT on openSUSE Leap 16 by default (boo#1243096) to Add support to use a different crt (boo#1243096) 2025-05-16 10:54:39 +02:00
rhabacker requested review from jengelh 2025-05-16 11:02:50 +02:00
michals commented 2025-05-16 11:13:29 +02:00
First-time contributor
Copy Link

ugh, this is nasty.

This means that if anyone links the package to other project they will get another result.

ugh, this is nasty. This means that if anyone links the package to other project they will get another result.
jengelh approved these changes 2025-06-04 13:14:13 +02:00
Dismissed
jengelh commented 2025-06-04 13:15:59 +02:00
Owner
Copy Link

(I finally found the "accept review" button in gitea)

I concur with michals in that limiting ucrt to just "%_repository=16" is bad style, and it should just be unconditionally used. For now, we can try a first build with that, though.

(I finally found the "accept review" button in gitea) I concur with michals in that limiting ucrt to just "%_repository=16" is bad style, and it should just be unconditionally used. For now, we can try a first build with that, though.
jengelh approved these changes 2025-06-04 13:17:48 +02:00
jengelh merged commit 6fc2bce094 into master 2025-06-04 13:18:17 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
jengelh
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm fstrba jengelh msmeissn rhabacker
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: mingw/mingw64-headers#2
No description provided.
Delete Branch "rhabacker/mingw64-headers:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?