mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-02-04 02:26:16 +01:00
Code

Do not supersede the same requests several times in osc creq

Browse Source 
When calling "osc creq -a prj1 foo prj2 bar -a submit prj1 bar prj2 bar",
the requests that could be superseded are calculated two times for the
prj2/bar package. Hence, they could end up two times in the "supersede"
list (see do_createrequest) In order to avoid duplicates, use a set
instead of a list.

Kudos to darix for pointing this out!

Note: it is a bit questionable if osc's current semantics makes sense
in the above example.
This commit is contained in:
Marcus Huewe 2020-12-09 21:41:37 +01:00
parent 745dc1180d
commit 1aab0a8ed9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osc/commandline.py
View File

@ -1840,14 +1840,14 @@ Please submit there instead, or use --nodevelproject to force direct submission.
i = 0
actionsxml = ""
supersede = []
supersede = set()
for ai in opts.actions:
if ai == 'submit':
args = opts.actiondata[i]
i = i+1
actions, to_supersede = self._submit_request(args, opts, options_block)
actionsxml += actions
supersede.extend(to_supersede)
supersede.update(to_supersede)
elif ai == 'delete':
args = opts.actiondata[i]
actionsxml += self._delete_request(args, opts)