mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-08-06 15:43:39 +02:00
Code Activity

changed change_request_state() to return only the status code

Browse Source 
Changed change_request_state() to return only the status code,
print out some more usable message for result of change_request_state()
where needed.
This commit is contained in:
Danny Kukawka
2010-08-18 16:17:34 +02:00
parent c93baf1f58
commit 2aede1039f
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osc/commandline.py
View File

@@ -1764,7 +1764,7 @@ Please submit there instead, or use --nodevelproject to force direct submission.
print result.reqid, ": ",
r = change_request_state(apiurl,
str(result.reqid), 'accepted', opts.message or '')
print r
print 'Result of change request state: %s' % r
else:
print >>sys.stderr, 'Aborted...'
raise oscerr.UserAbort()
@@ -1821,12 +1821,12 @@ Please submit there instead, or use --nodevelproject to force direct submission.
if cmd in ['accept', 'decline', 'new']:
r = change_review_state(apiurl,
reqid, state_map[cmd], conf.config['user'], opts.message or '')
print r
print % r
# Change state of entire request
elif cmd in ['reopen', 'accept', 'decline', 'wipe', 'revoke']:
r = change_request_state(apiurl,
reqid, state_map[cmd], opts.message or '')
print r
print 'Result of change request state: %s' % r
# editmeta and its aliases are all depracated
@cmdln.alias("editprj")

7
osc/core.py
View File

@@ -2836,8 +2836,13 @@ def change_request_state(apiurl, reqid, newstate, message='', supersed=''):
['request', reqid],
query={'cmd': 'changestate', 'newstate': newstate, 'superseded_by': supersed})
f = http_POST(u, data=message)
return f.read()
r = f.read()
if r.startswith('<status code="'):
r = r.split('<status code="')[1]
r = r.split('" />')[0]
return r
def get_review_list(apiurl, project='', package='', user='', group='', states=('new')):
xpath = ''