mirrors/github.com_openSUSE_osc
1
0
Fork 0
mirror of https://github.com/openSUSE/osc.git synced 2025-02-02 17:56:15 +01:00
Code

Reopening reviews only works for requests in state 'new' or 'review'

Browse Source
This commit is contained in:
Sascha Peilicke 2011-08-18 11:40:21 +02:00
parent 7acf236662
commit 3619f392a0
1 changed files with 19 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
osc/commandline.py
View File

@ -2071,27 +2071,28 @@ Please submit there instead, or use --nodevelproject to force direct submission.
opts.message = edit_message() opts.message = edit_message()
if cmd in ['accept', 'decline', 'reopen', 'supersede']: if cmd in ['accept', 'decline', 'reopen', 'supersede']:
if opts.user or opts.group or opts.project or opts.package: if opts.user or opts.group or opts.project or opts.package:
r = change_review_state(apiurl, r = change_review_state(apiurl, reqid, state_map[cmd], opts.user, opts.group, opts.project,
reqid, state_map[cmd], opts.user, opts.group, opts.project, opts.package, opts.message or '', supersed=supersedid) opts.package, opts.message or '', supersed=supersedid)
print r print r
else: else:
# try all, but do not fail on error
rq = get_request(apiurl, reqid) rq = get_request(apiurl, reqid)
for review in rq.reviews: if rq.state.name in ['new', 'review']:
if review.state == "new": for review in rq.reviews: # try all, but do not fail on error
try: try:
r = change_review_state(apiurl, r = change_review_state(apiurl, reqid, state_map[cmd], review.by_user, review.by_group,
reqid, state_map[cmd], review.by_user, review.by_group, review.by_project, review.by_package, opts.message or '', supersed=supersedid) review.by_project, review.by_package, opts.message or '', supersed=supersedid)
print r print r
except urllib2.HTTPError, e: except urllib2.HTTPError, e:
if review.by_user: if review.by_user:
print 'No permission on review by user %s' % review.by_user print 'No permission on review by user %s' % review.by_user
if review.by_group: if review.by_group:
print 'No permission on review by group %s' % review.by_group print 'No permission on review by group %s' % review.by_group
if review.by_package: if review.by_package:
print 'No permission on review by package %s / %s' % (review.by_project, review.by_package) print 'No permission on review by package %s / %s' % (review.by_project, review.by_package)
elif review.by_project: elif review.by_project:
print 'No permission on review by project %s' % review.by_project print 'No permission on review by project %s' % review.by_project
else:
print 'Request is closed, please reopen the request first before changing any reviews.'
# Change state of entire request # Change state of entire request
elif cmd in ['reopen', 'accept', 'decline', 'wipe', 'revoke', 'supersede']: elif cmd in ['reopen', 'accept', 'decline', 'wipe', 'revoke', 'supersede']:
rq = get_request(apiurl, reqid) rq = get_request(apiurl, reqid)