1
0
mirror of https://github.com/openSUSE/osc.git synced 2025-08-05 07:03:38 +02:00

Merge pull request #1202 from dmach/fix-empty-EDITOR-PAGER

Handle empty EDITOR=/PAGER= env variable properly
This commit is contained in:
2022-12-07 16:13:39 +01:00
committed by GitHub

View File

@@ -4197,7 +4197,8 @@ def run_pager(message, tmp_suffix=''):
else:
tmpfile.write(message)
tmpfile.flush()
pager = os.getenv('PAGER', default=get_default_pager())
pager = os.getenv("PAGER", default="").strip()
pager = pager or get_default_pager()
cmd = shlex.split(pager) + [tmpfile.name]
try:
run_external(*cmd)
@@ -4212,7 +4213,8 @@ def run_editor(filename):
def _editor_command():
editor = os.getenv('EDITOR', default=get_default_editor())
editor = os.getenv("EDITOR", default="").strip()
editor = editor or get_default_editor()
try:
cmd = shlex.split(editor)
except SyntaxError: