su-wrapper = su -c has been broken since commit 5376580. Handle this
case so that people do not have to update their configs.
Signed-off-by: Michal Marek <mmarek@suse.cz>
- rewrote Action class: instances only provide attributes for their specific type (for details see class doc).
Renamed "dst_project" attribute to "tgt_project" and "dst_package" attribute to "tgt_package" (only affects
types which have a <target /> element)
- added AbstractState class: Base class which represents state-like objects (<review />, <state />)
- rewrote ReviewState and RequestState classes
- rewrote Request class: apart from internal rewrites the format of the "__str__" and "list_view" methods
slightly changed
Now it should be much easier to create new requests without constructing the
request xml by hand.
Example:
r = Request()
r.add_action('submit', src_project='foo', src_package='bar', tgt_project='targetprj', tgt_package='targetpkg')
r.add_action('set_bugowner', tgt_project='foobar', person_name='buguser')
r.add_action('delete', tgt_project='prj', tgt_package='deleteme')
print r.to_str()
->
<request>
<action type="submit">
<source package="bar" project="foo" />
<target package="targetpkg" project="targetprj" />
</action>
<action type="set_bugowner">
<target project="foobar" />
<person name="buguser" />
</action>
<action type="delete">
<target package="deleteme" project="prj" />
</action>
</request>
This shows all the hard to retrieve, but 'essential' details about a
package: version, revision, srcmd5
If there is a better way some day, than digging through _history,
please improve core.py:get_source_rev()
It is a new option, only because it is so slow; the version
number should rather be in default output.
This shows all changes since branching, be they committed or not.
Implementation folded into do_diff() for reuse of code, although
this can behave quite differently.
- removed getStatus
- added the following new methods to the Project class:
* get_status: get the status of all packages in the project
* status: get the status of a single package
* get_pacobj: return a new Package object
- added the following new method to the Package class:
* get_status: get the status of all files in the package
- do_commit: fixed getStatus() call
- do_status: rewrite (uses new methods)
Revert a part of b3c5204, the do_main has to have at least one
argument, unless following exception will appear
osc.cmdln.CmdlnError: incorrect argcount for do_man(): takes 1, must
take 2 for 'argv' signature or 3+ for 'opts' signature
Signed-off-by: Petr Uzel <puzel@suse.cz>
Signed-off-by: Michal Vyskocil <mvyskocil@suse.cz>
Fix situation where osc has added a blank username to the keyring and
update the config parse script to do the right thing and not allow blank
usernames.
I was in a very confusing situation where my keyring ended up with two
entries:
- @api.suse.de
- philipsb@api.suse.de
And I was getting 401s because of it.
Signed-off-by: Brandon Philips <bphilips@suse.de>
There is a bug either in buildservice or in iChain which sometimes
truncates data and sends empty Content-Length header (see bnc#656281).
This patch makes osc retry request to workaround this problem.
The number of retries are configurable in config file as http_retries.
Flagged 'ls' without arguments as deprecated. This should really list
relative to the working directory rather than all projects.
It's now consistent with running 'osc r' in PRJ/PKG working directory.
On Thursday 04 November 2010, Sascha Peilicke wrote:
> Could you please send a patch file?
attached.
Greetings,
Dirk
From ac737b9ff8205fe3c320ee0b41b093c7ad92c348 Mon Sep 17 00:00:00 2001
From: Dirk Mueller <dmueller@suse.de>
Date: Thu, 4 Nov 2010 11:01:08 +0100
Subject: [PATCH] linkpac: Only include src_project if it differs
osc copypac copies _link files verbatim, so if they refer
to the same project, copying them should make them also
refer to the new project. This can be done by leaving
out the project part if it is the same like the destination
project
The previous convention of allowing multiple packages has caused
accidental deletion of packages while deleting files was intended (which
doesn't work that way). e.g. osc rdelete foo/bar/baz.spec would delete
foo/bar and then fail trying to delete foo/baz.spec
Also calling osc rdelete with accidental slash, e.g. osc rdelete
/foo/bar actually deleted project foo including all it's packages
without asking questions.
Both traps are eliminated now.
WARNING: source_validator_directory configured but it does not exist:
/usr/lib/osc/source_validators
Install osc-source_validator to fix.
Signed-off-by: Brandon Philips <bphilips@suse.de>
--stdin: read value from stdin
--prompt: prompt for a value
--no-echo: prompt for a value but don't echo entered characters (for instance to enter a passwd)
- store_read_apiurl: raise WorkingCopyInconsistent if dir is a wc, defaulturl is False
and ".osc/_apiurl" doesn't exist (otherwise NoWorkingCopy is raised)
- WorkingCopyInconsistent: add new attribute which contains the dirty files
- store_read_apiurl: added "defaulturl=True" parameter to return the
default apiurl if no '_apiurl' file exists (or if an exception is
raised while trying to read the '_apiurl' file)
Now "myProxyHTTPSConnection" inherits from "M2Crypto.httpslib.ProxyHTTPSConnection" _and_ "httplib.HTTPSConnection".
The latter class is only used to call "httplib.HTTPSConnection.endheaders". This multiple inheritance shouldn't have any side-effects
because "M2Crypto.httpslib.ProxyHTTPSConnection" already inherits from "httplib.HTTPSConnection" (and mro will pick the methods from
"M2Crypto.httpslib.ProxyHTTPSConnection" first).
We also do this for "osc request show -d" and similar friends.
Also, make run_pager() handle the case where the string is empty,
instead of having to make the caller handle it.
Both commands now check the current working-copy path if no arguments
are given and return the respective maintainer/bugowner.
Related to that, the help messages where updated and changed slightly
to look more similar.
- util/rpmquery:
* added new methods "is_src", "is_nosrc" to check if the package is
a src rpm or nosrc rpm
* fixed "canonname": this never worked for src- or nosrc rpms
- minor code restructuring
Note:
in order to fetch the cpio archives osc uses "getbinarylist". The
drawback is that "getbinarylist" doesn't generate an ".errors" file
if we're requesting a non-existent filename.
- get_diff:
* more helpful error message if a file was added and the local
file was removed again
* unify self.filenamelist and self.to_be_added if self.todo is empty
* extended testcases
- do_status: be able to run "osc st <nonexistentfile>"
