Accepting request 1301470 from GNOME:Factory

- Update to version 1.12.3:
  + Fix bug that caused that the challenge prompt didn't appear if
    it contained some special characters. (forwarded request 1301435 from iznogood)

OBS-URL: https://build.opensuse.org/request/show/1301470
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/NetworkManager-openvpn?expand=0&rev=97

NetworkManager-openvpn-1.12.3.tar.xz

@@ -0,0 +1,3 @@
+version https://git-lfs.github.com/spec/v1
+oid sha256:4bda1c8559bb8c35f6f131c09edae90cdfccd0314e8b8cb98ac55e09b6005adc
+size 724904

NetworkManager-openvpn.changes

@@ -1,3 +1,29 @@
+-------------------------------------------------------------------
+Tue Aug 26 12:22:22 UTC 2025 - Bjørn Lie <bjorn.lie@gmail.com>
+
+- Update to version 1.12.3:
+  + Fix bug that caused that the challenge prompt didn't appear if
+    it contained some special characters.
+
+-------------------------------------------------------------------
+Mon Aug 11 13:33:47 UTC 2025 - Bjørn Lie <bjorn.lie@gmail.com>
+
+- Update to version 1.12.2:
+  + Fix bug that caused that challenge was incorrectly reused if
+    invalid or expired.
+  + Add support for "data-ciphers-fallback" option.
+  + Add GUI support for "data-ciphers" option.
+  + Fix export for password connection type that was not exporting
+    some fields.
+  + Fix mnemonics in editor's Identity - Advanced view
+  + Auth-dialog ported to GTK4
+  + Import certificates into the XDG_DATA_HOME directory.
+  + Updated translations.
+- Drop nm-openvpn-fix-crash.patch: Fixed upstream (in a slightly
+  different way).
+- Rebase fix-for-missing-whirlpool-hmac-authentication.patch with
+  quilt.
+
 -------------------------------------------------------------------
 Tue Mar  4 06:10:20 UTC 2025 - Jonathan Kang <songchuan.kang@suse.com>
 

NetworkManager-openvpn.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package NetworkManager-openvpn
 #
-# Copyright (c) 2025 SUSE LLC
+# Copyright (c) 2025 SUSE LLC and contributors
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
 
 
 Name:           NetworkManager-openvpn
-Version:        1.12.0
+Version:        1.12.3
 Release:        0
 Summary:        NetworkManager VPN support for OpenVPN
 License:        GPL-2.0-or-later
@@ -27,8 +27,6 @@ Source0:        https://download.gnome.org/sources/NetworkManager-openvpn/1.12/%
 Source1:        system-user-nm-openvpn.conf
 # PATCH-FIX-OPENSUSE fix-for-missing-whirlpool-hmac-authentication.patch boo#1132946
 Patch0:         fix-for-missing-whirlpool-hmac-authentication.patch
-# PATCH-FIX-UPSTREAM nm-openvpn-fix-crash.patch glgo#GNOME/NetworkManager-openvpn!92, bsc#1237570 sckang@suse.com -- service: fix a crash when empty password is provided
-Patch1:         nm-openvpn-fix-crash.patch
 
 BuildRequires:  libxml2-tools
 BuildRequires:  pkgconfig

fix-for-missing-whirlpool-hmac-authentication.patch

@@ -1,8 +1,8 @@
-Index: NetworkManager-openvpn-1.10.0/properties/nm-openvpn-editor.c
+Index: NetworkManager-openvpn-1.12.2/properties/nm-openvpn-editor.c
 ===================================================================
---- NetworkManager-openvpn-1.10.0.orig/properties/nm-openvpn-editor.c
-+++ NetworkManager-openvpn-1.10.0/properties/nm-openvpn-editor.c
-@@ -1020,6 +1020,7 @@ populate_hmacauth_combo (GtkComboBox *bo
+--- NetworkManager-openvpn-1.12.2.orig/properties/nm-openvpn-editor.c
++++ NetworkManager-openvpn-1.12.2/properties/nm-openvpn-editor.c
+@@ -1027,6 +1027,7 @@ populate_hmacauth_combo (GtkComboBox *bo
  		{ NM_OPENVPN_AUTH_SHA384,    N_("SHA-384") },
  		{ NM_OPENVPN_AUTH_SHA512,    N_("SHA-512") },
  		{ NM_OPENVPN_AUTH_RIPEMD160, N_("RIPEMD-160") },
@@ -10,11 +10,11 @@ Index: NetworkManager-openvpn-1.10.0/properties/nm-openvpn-editor.c
  	};
  
  	store = gtk_list_store_new (3, G_TYPE_STRING, G_TYPE_STRING, G_TYPE_BOOLEAN);
-Index: NetworkManager-openvpn-1.10.0/shared/nm-service-defines.h
+Index: NetworkManager-openvpn-1.12.2/shared/nm-service-defines.h
 ===================================================================
---- NetworkManager-openvpn-1.10.0.orig/shared/nm-service-defines.h
-+++ NetworkManager-openvpn-1.10.0/shared/nm-service-defines.h
-@@ -112,6 +112,7 @@
+--- NetworkManager-openvpn-1.12.2.orig/shared/nm-service-defines.h
++++ NetworkManager-openvpn-1.12.2/shared/nm-service-defines.h
+@@ -119,6 +119,7 @@
  #define NM_OPENVPN_AUTH_SHA256    "SHA256"
  #define NM_OPENVPN_AUTH_SHA384    "SHA384"
  #define NM_OPENVPN_AUTH_SHA512    "SHA512"

nm-openvpn-fix-crash.patch

@@ -1,60 +0,0 @@
-From a65f66d2de6f259f08be30a3a9e03827674acdcf Mon Sep 17 00:00:00 2001
-From: Jonathan Kang <jonathankang@gnome.org>
-Date: Mon, 3 Mar 2025 13:52:27 +0800
-Subject: [PATCH] service: fix a crash when empty password is provided
-
-When activating a VPN connection with the following command, if no
-password is provided, nm-openvpn-service crashes.
-
-> nmcli --ask connection up $vpn-connection
-
-Fix that by additionally checking for empty password to avoid passing
-NULL to strlen().
-
-https://bugzilla.suse.com/show_bug.cgi?id=1237570
----
- src/nm-openvpn-service.c | 25 ++++++++++++++++---------
- 1 file changed, 16 insertions(+), 9 deletions(-)
-
-diff --git a/src/nm-openvpn-service.c b/src/nm-openvpn-service.c
-index a58124d..b01671d 100644
---- a/src/nm-openvpn-service.c
-+++ b/src/nm-openvpn-service.c
-@@ -781,18 +781,25 @@ nm_openvpn_disconnect_management_socket (NMOpenvpnPlugin *plugin)
- static char *
- ovpn_quote_string (const char *unquoted)
- {
--	char *quoted = NULL, *q;
--	char *u = (char *) unquoted;
-+	char *quoted = NULL;
- 
- 	g_return_val_if_fail (unquoted != NULL, NULL);
- 
--	/* FIXME: use unpaged memory */
--	quoted = q = g_malloc0 (strlen (unquoted) * 2);
--	while (*u) {
--		/* Escape certain characters */
--		if (*u == ' ' || *u == '\\' || *u == '"')
--			*q++ = '\\';
--		*q++ = *u++;
-+	/* Check empty password to avoid segmentation fault. */
-+	if (g_strcmp0 (unquoted, "") == 0)
-+		quoted = g_strdup (unquoted);
-+	else {
-+		char *q;
-+		char *u = (char *) unquoted;
-+
-+		/* FIXME: use unpaged memory */
-+		quoted = q = g_malloc0 (strlen (unquoted) * 2);
-+		while (*u) {
-+			/* Escape certain characters */
-+			if (*u == ' ' || *u == '\\' || *u == '"')
-+				*q++ = '\\';
-+			*q++ = *u++;
-+		}
- 	}
- 
- 	return quoted;
--- 
-2.48.1
-