pool/cockpit-subscriptions
SHA256
19
0
Fork 2
Code Issues Pull Requests Activity

Update cocpkit subscriptions to version 10 #8

Manually merged
ldragon merged 1 commits from ldragon/cockpit-subscriptions:main into main 2025-07-10 10:11:33 +02:00
Conversation 10 Commits 1 Files Changed 7 +431 -432
ldragon commented 2025-05-02 11:12:40 +02:00
Contributor
Copy Link
No description provided.
abrooks requested changes 2025-05-02 11:21:42 +02:00
Dismissed
cockpit-subscriptions.changes Outdated
@@ -1,3 +1,12 @@
-------------------------------------------------------------------
Fri May 2 09:06:07 UTC 2025 - Luna D Dragon <luna.dragon@suse.com>
- Upgrade to patternfly 6
abrooks commented 2025-05-02 11:20:36 +02:00
Contributor
Copy Link

Those should be subheadings under - Upgrade to version 9

Those should be subheadings under - Upgrade to version 9
ldragon commented 2025-05-02 11:38:33 +02:00
Author
Contributor
Copy Link

done

done
ldragon marked this conversation as resolved
cockpit-subscriptions.spec Outdated
@@ -24,7 +24,6 @@ License: LGPL-2.1-or-later
Source0: ./cockpit-subscriptions-%{version}.tar.xz
Source10: package-lock.json
Source11: node_modules.spec.inc
Source12: update_version.sh
abrooks commented 2025-05-02 11:21:36 +02:00
Contributor
Copy Link

The update_version.sh script needs to be added here otherwise it'll get rejected in other downstream repo's (yeah I know it got removed by the update_version script, I need to fix it)

The update_version.sh script needs to be added here otherwise it'll get rejected in other downstream repo's (yeah I know it got removed by the update_version script, I need to fix it)
ldragon commented 2025-05-02 11:41:07 +02:00
Author
Contributor
Copy Link

done

done
ldragon marked this conversation as resolved
ldragon force-pushed main from bc553a47bb to 1867f3625d 2025-05-02 11:40:50 +02:00 Compare
abrooks approved these changes 2025-05-02 11:42:29 +02:00
Dismissed
adamm requested review from adamm 2025-05-07 15:57:29 +02:00
adamm requested review from jzerebecki 2025-05-07 15:57:29 +02:00
adamm requested review from malikirri 2025-05-07 15:57:29 +02:00
malikirri reviewed 2025-05-08 09:28:21 +02:00
malikirri left a comment
First-time contributor
Copy Link

Considering that the UI is very broken in this version, I don't think we should release this one at all and jump straight to version 10.

The UI fixes have already been merged in: https://github.com/openSUSE/cockpit-subscriptions/pull/125

Considering that the UI is very broken in this version, I don't think we should release this one at all and jump straight to version 10. The UI fixes have already been merged in: https://github.com/openSUSE/cockpit-subscriptions/pull/125
👍 2
ldragon changed title from Update cocpkit subscriptions to version 9 to Update cocpkit subscriptions to version 10 2025-05-08 11:09:43 +02:00
ldragon added 1 commit 2025-05-08 11:11:30 +02:00
update cockpit-subscriptions to 10 8d549e48e4
ldragon commented 2025-05-08 11:12:06 +02:00
Author
Contributor
Copy Link

bumped to 10

bumped to 10
adamm requested review from malikirri 2025-05-08 11:21:18 +02:00
adamm requested review from abrooks 2025-05-08 11:21:18 +02:00
abrooks approved these changes 2025-05-08 12:04:57 +02:00
malikirri approved these changes 2025-05-08 12:19:12 +02:00
adamm requested review from Ghost Team 2025-05-08 17:16:23 +02:00
Ghost commented 2025-05-08 17:28:37 +02:00
Copy Link

Legal reviewed as acceptable_by_lawyer:

Accepted because previously reviewed under the same license (440864)
Legal reviewed as [acceptable_by_lawyer](https://legaldb.suse.de/reviews/details/447045): ``` Accepted because previously reviewed under the same license (440864) ```
Ghost approved these changes 2025-05-08 17:28:37 +02:00
adamm requested review from legaldb 2025-05-09 11:39:20 +02:00
legaldb commented 2025-05-09 11:55:07 +02:00
Member
Copy Link

Legal reviewed as acceptable_by_lawyer:

Accepted because previously reviewed under the same license (440864)
Legal reviewed as [acceptable_by_lawyer](https://legaldb.suse.de/reviews/details/447045): ``` Accepted because previously reviewed under the same license (440864) ```
report.md
1.9 KiB
legaldb approved these changes 2025-05-09 11:55:07 +02:00
ldragon manually merged commit 8d549e48e4 into main 2025-05-09 16:39:11 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
adamm
jzerebecki
abrooks
malikirri
Ghost
legaldb
Labels
Clear labels
legaldb
Critical Priority
Critical legaldb priority
Archived
legaldb
High Priority
2
High legaldb priority
legaldb
Normal Priority
1
Normal legaldb priority
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm_super adrianSuSE autobuild-owner autobuild-review autogits_workflow_pr_bot bigironman dirkmueller eroca factory_bot gitea_test legaldb lkocman-factory maxlin_factory opensuse-review packagehub-review smithfarm
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pool/cockpit-subscriptions#8
Delete Branch "ldragon/cockpit-subscriptions:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?