pool/frozen-bubble
SHA256
20
0
Fork 1
Code Issues Pull Requests Activity

Accepting request 617546 from games

Browse Source 
- fix build for Tumbleweed (add silencebadsnprintfcheck.patch)

In my opinion the check is wrong. snprintf already checks target buffer overflow. Why test if the amount of possible outputs of individual components exceeds the target buffer. That's common practice. With this check defining a large intermediate buffer leads to an error, using short intermediate buffers has no error, but is more dangerous - That makes no sense!

OBS-URL: https://build.opensuse.org/request/show/617546
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/frozen-bubble?expand=0&rev=32
This commit is contained in:
Yuchen Lin
2018-06-20 13:30:22 +00:00
committed by Git OBS Bridge
parent 3b83382bbf 45b3b48551
commit a524dcd282
3 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frozen-bubble.changes
+5
View File
@@ -1,3 +1,8 @@
-------------------------------------------------------------------
Mon Jun 18 14:50:18 UTC 2018 - opensuse@dstoecker.de
- fix build for Tumbleweed (add silencebadsnprintfcheck.patch)
-------------------------------------------------------------------
Mon Mar 5 11:13:18 UTC 2018 - dimstar@opensuse.org
frozen-bubble.spec
+4 -1
View File
@@ -23,7 +23,7 @@ Release: 0
Summary: Puzzle with Bubbles
License: GPL-2.0-or-later
Group: Amusements/Games/Action/Arcade
URL: http://www.frozen-bubble.org/
Url: http://www.frozen-bubble.org/
Source0: http://www.frozen-bubble.org/data/frozen-bubble-2.2.1-beta1.tar.bz2
Source1: fb-server
Source2: fb-server.service
@@ -37,6 +37,8 @@ Patch3: frozen-bubble-2.212-unused-result.patch
Patch4: desktop.patch
# PATCH-FEATURE-UPSTREAM https://github.com/kthakore/frozen-bubble/pull/64
Patch5: appdata.patch
# PATCH-FIX-OPENSUSE get a strange check silent - what's the sense of checking snprintf when the buffer size is correct
Patch6: silencebadsnprintfcheck.patch
BuildRequires: Mesa-devel
BuildRequires: SDL_Pango-devel
BuildRequires: SDL_image-devel
@@ -102,6 +104,7 @@ cp server/init/README server/README.init
%patch3 -p1
%patch4 -p1
%patch5 -p1
%patch6 -p1
%build
perl Build.PL destdir=%{buildroot} installdirs=vendor --prefix=%{_prefix}
silencebadsnprintfcheck.patch
+12
View File
@@ -0,0 +1,12 @@
diff -ur frozen-bubble-2.212/server/log.c frozen-bubble-2.212_fix/server/log.c
--- frozen-bubble-2.212/server/log.c 2012-10-24 19:53:38.000000000 +0200
+++ frozen-bubble-2.212_fix/server/log.c 2018-06-18 16:44:51.963979828 +0200
@@ -56,7 +56,7 @@
char* get_current_date(void)
{
struct tm * lt;
- char buf[50];
+ char buf[30];
double time = get_current_time_exact();
time_t seconds = (time_t)time;
lt = localtime(&seconds);