pool/gamescope
SHA256
18
0
Fork 9
Code Issues Pull Requests Activity

Update to version 3.16.17 and merge changes from PR #13 #14

Closed
ateixeira wants to merge 0 commits from ateixeira/gamescope:factory into factory
pull from: ateixeira/gamescope:factory
merge into: pool:factory
Conversation 13 Commits - Files Changed 5 -7
ateixeira commented 2025-09-19 16:12:14 +02:00
Contributor
Copy Link

Update to version 3.16.17

  • steamcompmgr: Hold wlserver_lock around handle_presented_xdg
  • steamcompmgr: Disarm VRR timer
  • steamcompmgr: Never limit the FPS for the appid of the current VR Scene App
  • repaint on focus dirty
  • fix screenshot timeout in 2d/ui

This PR also manually merges the changes from #13 . It was accepted in Factory but the changes were lost in the git repo because the source branch was deleted before the PR was merged (see #13 (comment)). Not sure if this should be solved in some other way.

Update to version 3.16.17 * steamcompmgr: Hold wlserver_lock around handle_presented_xdg * steamcompmgr: Disarm VRR timer * steamcompmgr: Never limit the FPS for the appid of the current VR Scene App * repaint on focus dirty * fix screenshot timeout in 2d/ui This PR also manually merges the changes from #13 . It was accepted in Factory but the changes were lost in the git repo because the source branch was deleted before the PR was merged (see https://src.opensuse.org/pool/gamescope/pulls/13#issuecomment-27364). Not sure if this should be solved in some other way.
ateixeira added 2 commits 2025-09-19 16:12:15 +02:00
Remove pkgconfig(freerdp2) BuildRequires: there is no mention of 85bfdf839d 
freerdp in the source tree on either gamescope or wlroots.
Update to version 3.16.17 becb203dff 
* steamcompmgr: Hold wlserver_lock around handle_presented_xdg
* steamcompmgr: Disarm VRR timer
* steamcompmgr: Never limit the FPS for the appid of the current VR Scene App
* repaint on focus dirty
* fix screenshot timeout in 2d/ui
src-o-org-forwarder commented 2025-09-19 16:12:23 +02:00
First-time contributor
Copy Link

Created submit request sr#1306027

Created submit request [sr#1306027](https://build.opensuse.org/request/show/1306027)
iznogood commented 2025-09-19 20:02:59 +02:00
First-time contributor
Copy Link

Thanks ateixeira for fixing up my mistake - I guess we have "hole" here in the process making my mistake possible.

I also wonder why your pull automagically triggered src-o-org-forwarder doing the "SR"? - mine needed manual interventions, and the SR was from someone else towards factory.

Thanks ateixeira for fixing up my mistake - I guess we have "hole" here in the process making my mistake possible. I also wonder why your pull automagically triggered src-o-org-forwarder doing the "SR"? - mine needed manual interventions, and the SR was from someone else towards factory.
smithfarm commented 2025-09-22 10:48:33 +02:00
Owner
Copy Link

I also wonder why your pull automagically triggered src-o-org-forwarder doing the "SR"?

That's because Factory is not yet using the git workflow. Changes to Factory should be submitted "as usual": first, land the change in the devel project, second, SR from devel to openSUSE:Factory.

It looks like the forwarded SR ( https://build.opensuse.org/requests/1306027 ) was accepted in this case, though!

> I also wonder why your pull automagically triggered src-o-org-forwarder doing the "SR"? That's because Factory is not yet using the git workflow. Changes to Factory should be submitted "as usual": first, land the change in the devel project, second, SR from devel to openSUSE:Factory. It looks like the forwarded SR ( https://build.opensuse.org/requests/1306027 ) was accepted in this case, though!
smithfarm closed this pull request 2025-09-22 10:48:33 +02:00
iznogood commented 2025-09-22 10:58:31 +02:00
First-time contributor
Copy Link

But should this merge not be acked?
Now there is a diff in the devel repo vs factory?
With factory beeing 2 commits ahead.

But should this merge not be acked? Now there is a diff in the devel repo vs factory? With factory beeing 2 commits ahead.
iznogood commented 2025-09-22 11:01:14 +02:00
First-time contributor
Copy Link

See
osc rdiff openSUSE:Factory gamescope games:tools gamescope

See `osc rdiff openSUSE:Factory gamescope games:tools gamescope`
ateixeira commented 2025-09-23 19:22:25 +02:00
Author
Contributor
Copy Link

I also wonder why your pull automagically triggered src-o-org-forwarder doing the "SR"?

That's because Factory is not yet using the git workflow. Changes to Factory should be submitted "as usual": first, land the change in the devel project, second, SR from devel to openSUSE:Factory.

It looks like the forwarded SR ( https://build.opensuse.org/requests/1306027 ) was accepted in this case, though!

Yes, the repo for this package was set up with git quite a few months ago at a point when it was experimental and the existing guide I had at the time directed maintainers towards doing the scmsync config in the devel project. (see: https://en.opensuse.org/openSUSE:OBS_with_Git#Warnings_about_the_scm-staging_user_guide)

So, should I remove the scmsync config entirely and just use OBS for now until Factory starts using the git workflow?

> > I also wonder why your pull automagically triggered src-o-org-forwarder doing the "SR"? > > That's because Factory is not yet using the git workflow. Changes to Factory should be submitted "as usual": first, land the change in the devel project, second, SR from devel to openSUSE:Factory. > > It looks like the forwarded SR ( https://build.opensuse.org/requests/1306027 ) was accepted in this case, though! Yes, the repo for this package was set up with git quite a few months ago at a point when it was experimental and the existing guide I had at the time directed maintainers towards doing the scmsync config in the devel project. (see: https://en.opensuse.org/openSUSE:OBS_with_Git#Warnings_about_the_scm-staging_user_guide) So, should I remove the scmsync config entirely and just use OBS for now until Factory starts using the git workflow?
smithfarm reopened this pull request 2025-09-24 11:34:42 +02:00
src-o-org-forwarder commented 2025-09-24 11:34:52 +02:00
First-time contributor
Copy Link

Created submit request sr#1306878

Created submit request [sr#1306878](https://build.opensuse.org/request/show/1306878)
smithfarm commented 2025-09-24 11:43:06 +02:00
Owner
Copy Link

If I understand correctly, the devel project https://build.opensuse.org/project/show/games:tools has not been migrated to git, but just the gamescope package within it has scmsync in its OBS package metadata.

I guess that explains why the Factory SR was accepted in this case.

I believe it should be possible to do osc sr game:tools gamescope openSUSE:Factory as usual, even when the package has scmsync. Have you tried that?

If I understand correctly, the devel project https://build.opensuse.org/project/show/games:tools has not been migrated to git, but just the gamescope package within it has scmsync in its OBS package metadata. I guess that explains why the Factory SR was accepted in this case. I believe it should be possible to do `osc sr game:tools gamescope openSUSE:Factory` as usual, even when the package has scmsync. Have you tried that?
smithfarm commented 2025-09-24 11:47:08 +02:00
Owner
Copy Link

The factory branch of this git repo should be automatically synced with openSUSE:Factory/gamescope. It's possible that there might be a delay, though, which would explain why factory branch fell behind when sr#1306878 was accepted.

The `factory` branch of this git repo should be automatically synced with `openSUSE:Factory/gamescope`. It's possible that there might be a delay, though, which would explain why `factory` branch fell behind when sr#1306878 was accepted.
smithfarm commented 2025-09-24 11:48:13 +02:00
Owner
Copy Link

@ateixeira If you can merge this, please feel free to do so... (I cannot merge it in its current state). But I still think the factory branch will eventually get synced even without merging this PR.

@ateixeira If you can merge this, please feel free to do so... (I cannot merge it in its current state). But I still think the factory branch will eventually get synced even without merging this PR.
iznogood commented 2025-09-24 12:32:40 +02:00
First-time contributor
Copy Link

Adding @adamm and @dirkmueller - what went wrong here? - aka did we do something wrong? #13 (comment) states that the devel repo should have been updated when the sr / merge was acked into factory?

Adding @adamm and @dirkmueller - what went wrong here? - aka did we do something wrong? https://src.opensuse.org/pool/gamescope/pulls/13#issuecomment-26968 states that the devel repo should have been updated when the sr / merge was acked into factory?
dimstar commented 2025-09-24 13:15:59 +02:00
First-time contributor
Copy Link

Adding @adamm and @dirkmueller - what went wrong here? - aka did we do something wrong? #13 (comment) states that the devel repo should have been updated when the sr / merge was acked into factory?

the bot syncing from openSUSE:Factory to src.o.o/pool/ seems to have missed the package having changed in openSUSE:Factory - and as a consequence, the devel project (which uses an scmsync URL to pool - which is weird on its own) does not get the update

> Adding @adamm and @dirkmueller - what went wrong here? - aka did we do something wrong? https://src.opensuse.org/pool/gamescope/pulls/13#issuecomment-26968 states that the devel repo should have been updated when the sr / merge was acked into factory? the bot syncing from openSUSE:Factory to src.o.o/pool/ seems to have missed the package having changed in openSUSE:Factory - and as a consequence, the devel project (which uses an scmsync URL to pool - which is weird on its own) does not get the update
dirkmueller closed this pull request 2025-09-24 14:05:27 +02:00
iznogood commented 2025-09-24 15:06:38 +02:00
First-time contributor
Copy Link

https://build.opensuse.org/package/show/games:tools/gamescope -> now broken

https://build.opensuse.org/package/show/games:tools/gamescope -> now broken

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
legaldb
Critical Priority
Critical legaldb priority
Archived
legaldb
High Priority
2
High legaldb priority
legaldb
Normal Priority
1
Normal legaldb priority
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm_super adrianSuSE autobuild-owner autobuild-review autogits_workflow_pr_bot bigironman dirkmueller eroca factory_bot gitea_test legaldb lkocman-factory maxlin_factory opensuse-review packagehub-review smithfarm
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pool/gamescope#14
Delete Branch "ateixeira/gamescope:factory"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?