- Patches added:

* gdb-testsuite-fix-gdb.mi-mi-sym-info.exp-on-opensuse-tumbleweed.patch
- Maintenance script qa.sh:
  * Add PR26873 kfails.

OBS-URL: https://build.opensuse.org/package/show/devel:gcc/gdb?expand=0&rev=334
This commit is contained in:
Tom de Vries 2022-09-29 06:03:26 +00:00 committed by Git OBS Bridge
parent 3608b5ef76
commit a6077b67a9
4 changed files with 56 additions and 0 deletions

View File

@ -0,0 +1,39 @@
[gdb/testsuite] Fix gdb.mi/mi-sym-info.exp on openSUSE Tumbleweed
On openSUSE Tumbleweed, I run into:
...
FAIL: gdb.mi/mi-sym-info.exp: List all functions from debug information only
...
The problem is in matching this string:
...
{name="_start",type="void (void)",description="void _start(void);"}
...
using regexp fun_re, which requires a line field:
...
set fun_re \
"\{line=\"$decimal\",name=${qstr},type=${qstr},description=${qstr}\}"
...
Fix this by making the line field optional in fun_re.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.mi/mi-sym-info.exp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.mi/mi-sym-info.exp b/gdb/testsuite/gdb.mi/mi-sym-info.exp
index 7b936061759..2f723ece882 100644
--- a/gdb/testsuite/gdb.mi/mi-sym-info.exp
+++ b/gdb/testsuite/gdb.mi/mi-sym-info.exp
@@ -38,7 +38,8 @@ mi_clean_restart $binfile
mi_runto_main
set qstr "\"\[^\"\]+\""
-set fun_re "\{line=\"$decimal\",name=${qstr},type=${qstr},description=${qstr}\}"
+set fun_re \
+ "\{(?:line=\"$decimal\",)?name=${qstr},type=${qstr},description=${qstr}\}"
set type_re "\{(?:line=\"$decimal\",)*name=${qstr}\}"
set sym_list "\\\[${fun_re}(?:,$fun_re)*\\\]"
set type_sym_list "\\\[${type_re}(?:,$type_re)*\\\]"

View File

@ -1,3 +1,11 @@
-------------------------------------------------------------------
Wed Sep 28 11:50:45 UTC 2022 - Tom de Vries <tdevries@suse.com>
- Patches added:
* gdb-testsuite-fix-gdb.mi-mi-sym-info.exp-on-opensuse-tumbleweed.patch
- Maintenance script qa.sh:
* Add PR26873 kfails.
-------------------------------------------------------------------
Fri Sep 23 09:46:57 UTC 2022 - Tom de Vries <tdevries@suse.com>

View File

@ -383,6 +383,8 @@ Patch2112: gdb-testsuite-fix-gdb.reverse-i387-env-reverse.exp-for-pie.patch
Patch2113: gdb-testsuite-fix-gdb.ada-literals.exp-with-aarch64.patch
# https://sourceware.org/bugzilla/show_bug.cgi?id=29423#c8
Patch2114: gdb-fix-watchpoints-triggered.patch
# https://sourceware.org/pipermail/gdb-patches/2022-September/192172.html
Patch2115: gdb-testsuite-fix-gdb.mi-mi-sym-info.exp-on-opensuse-tumbleweed.patch
# Debug patches.
@ -795,6 +797,7 @@ find -name "*.info*"|xargs rm -f
%patch2112 -p1
%patch2113 -p1
%patch2114 -p1
%patch2115 -p1
#unpack libipt
%if 0%{have_libipt}

6
qa.sh
View File

@ -241,6 +241,10 @@ kfail=(
# https://sourceware.org/bugzilla/show_bug.cgi?id=25038
"FAIL: gdb.reverse/test_ioctl_TCSETSW.exp: handle TCSETSW"
# https://sourceware.org/bugzilla/show_bug.cgi?id=26873
"FAIL: gdb.threads/watchthreads-threaded.exp: threaded watch loop \(GDB internal error\)"
) # kfail
kfail_sle12=(
@ -422,6 +426,8 @@ case $n in
# https://sourceware.org/bugzilla/show_bug.cgi?id=28667
"record-full.c:[0-9]*: internal-error: ptid_t record_full_wait_1\(target_ops\*, ptid_t, target_waitstatus\*, target_wait_flags\): Assertion \`\(options & TARGET_WNOHANG\) != 0' failed."
# https://sourceware.org/bugzilla/show_bug.cgi?id=26873
"infrun.c:[0-9]*: internal-error: resume_1: Assertion \`!\(thread_has_single_step_breakpoints_set \(tp\) && step\)' failed."
)
kfail_re=$(join "|" "${kfail[@]}")