Cleanup

OBS-URL: https://build.opensuse.org/package/show/devel:libraries:c_c++/gflags?expand=0&rev=2

gflags.spec

@@ -1,7 +1,7 @@
 #
 # spec file for package gflags
 #
-# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2018 SUSE LINUX GmbH, Nuernberg, Germany.
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed
@@ -12,7 +12,7 @@
 # license that conforms to the Open Source Definition (Version 1.9)
 # published by the Open Source Initiative.
 
-# Please submit bugfixes or comments via http://bugs.opensuse.org/
+# Please submit bugfixes or comments via https://bugs.opensuse.org/
 #
 
 
@@ -22,13 +22,12 @@ Release:        0
 Summary:        Library for commandline flag processing
 License:        BSD-3-Clause
 Group:          Development/Libraries/C and C++
-Url:            https://github.com/gflags/gflags
+URL:            https://github.com/gflags/gflags
 Source0:        https://github.com/%{name}/%{name}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
 BuildRequires:  cmake
 BuildRequires:  gcc-c++
 BuildRequires:  pkgconfig
 Requires:       libgflags2 = %{version}
-BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 
 %description
 The gflags package contains a library that implements commandline
@@ -48,7 +47,7 @@ string, and the ability to define flags in the source file in which
 they're used.
 
 %package devel
-Summary:        Include Files and Libraries mandatory for Development
+Summary:        Development files for gflags library
 Requires:       libgflags2 = %{version}
 
 %description devel
@@ -57,7 +56,7 @@ to develop applications that require the provided includes and
 libraries.
 
 %package devel-static
-Summary:        Include Files and Libraries mandatory for Development
+Summary:        Statically linked development libraries for gflags
 Requires:       %{name}-devel = %{version}
 
 %description devel-static
@@ -83,29 +82,27 @@ make %{?_smp_mflags} VERBOSE=1
 %install
 %cmake_install
 
+# Installs a file on $HOME, remove it
 rm -rf %{buildroot}/home/
 
 %check
-cd build
-export LD_LIBRARY_PATH=`pwd`/lib
-ctest
+export LD_LIBRARY_PATH=`pwd`/build/lib
+%ctest
 
 %post -n libgflags2 -p /sbin/ldconfig
 %postun -n libgflags2 -p /sbin/ldconfig
 
 %files
-%defattr(-,root,root)
-%doc AUTHORS.txt COPYING.txt ChangeLog.txt README.md
+%license COPYING.txt
+%doc AUTHORS.txt ChangeLog.txt README.md
 %{_bindir}/%{name}_completions.sh
 
 %files -n libgflags2
-%defattr(-,root,root)
-%doc COPYING.txt
+%license COPYING.txt
 %{_libdir}/libgflags.so.*
 %{_libdir}/libgflags_nothreads.so.*
 
 %files devel
-%defattr(-,root,root)
 %{_includedir}/%{name}/
 %{_libdir}/libgflags.so
 %{_libdir}/libgflags_nothreads.so
@@ -113,7 +110,6 @@ ctest
 %{_libdir}/pkgconfig/%{name}.pc
 
 %files devel-static
-%defattr(-,root,root)
 %{_libdir}/libgflags.a
 %{_libdir}/libgflags_nothreads.a