Accepting request 721710 from GNOME:Factory

- Add gse-apps-menu-Add_missing_chain-up.patch: PanelMenu.Button is
  a bit weird in that it also "contains" its parent actor. That
  container is supposed to be destroyed with the button, but as we
  currently don't chain up to the parent class' _onDestroy(), we
  leave behind an empty container every time the extension is
  disabled. Fix this by adding the missing chain-up.

OBS-URL: https://build.opensuse.org/request/show/721710
OBS-URL: https://build.opensuse.org/package/show/openSUSE:Factory/gnome-shell-extensions?expand=0&rev=89
This commit is contained in:
Dominique Leuenberger 2019-08-15 10:26:06 +00:00 committed by Git OBS Bridge
commit 0d0b512971
3 changed files with 51 additions and 1 deletions

View File

@ -1,3 +1,13 @@
-------------------------------------------------------------------
Fri Aug 2 18:08:38 UTC 2019 - Bjørn Lie <bjorn.lie@gmail.com>
- Add gse-apps-menu-Add_missing_chain-up.patch: PanelMenu.Button is
a bit weird in that it also "contains" its parent actor. That
container is supposed to be destroyed with the button, but as we
currently don't chain up to the parent class' _onDestroy(), we
leave behind an empty container every time the extension is
disabled. Fix this by adding the missing chain-up.
-------------------------------------------------------------------
Mon Jul 8 07:12:55 UTC 2019 - Chingkai <qkzhu@suse.com>

View File

@ -39,6 +39,9 @@ Patch1: gnome-shell-add-app-to-desktop.patch
Patch2: gnome-shell-favorites-menu-at-end.patch
# PATCH-FIX-OPENSUSE gnome-classic-s390-not-require-g-s-d_wacom.patch bsc#1129412 yfjiang@suse.com -- Remove the runtime requirement of g-s-d Wacom plugin
Patch3: gnome-classic-s390-not-require-g-s-d_wacom.patch
# PATCH-FIX-UPSTREAM gse-apps-menu-Add_missing_chain-up.patch -- apps-menu: Add missing chain-up
Patch4: gse-apps-menu-Add_missing_chain-up.patch
## NOTE keep SLE Classic patch at the bottom
# PATCH-FIX-SLE gse-sle-classic-ext.patch Fate#318572 cxiong@suse.com -- add sle classic support
Patch1000: gse-sle-classic-ext.patch
@ -114,6 +117,7 @@ gnome-shell classic.
%ifarch s390 s390x
%patch3 -p1
%endif
%patch4 -p1
translation-update-upstream po %{name}
gnome-patch-translation-prepare po %{name}
@ -222,7 +226,7 @@ ln -s %{_sysconfdir}/alternatives/default-waylandsession.desktop %{buildroot}%{_
%files -n gnome-shell-classic-session
%defattr(-,root,root)
%doc COPYING
%license COPYING
%{_datadir}/gnome-session/sessions/gnome-classic.session
%files common-lang -f %{name}.lang

View File

@ -0,0 +1,36 @@
From 13372e7e121209aa329b9784432dff8673b01d3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Thu, 27 Jun 2019 01:57:53 +0000
Subject: [PATCH] apps-menu: Add missing chain-up
PanelMenu.Button is a bit weird in that it also "contains" its parent
actor. That container is supposed to be destroyed with the button, but
as we currently don't chain up to the parent class' _onDestroy(), we
leave behind an empty container every time the extension is disabled.
Fix this by adding the missing chain-up.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/75
(cherry picked from commit dfeb99fc0a37051c33980b97a86c16f2ccdfa2bc)
---
extensions/apps-menu/extension.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/extensions/apps-menu/extension.js b/extensions/apps-menu/extension.js
index d7ba570..c657a7e 100644
--- a/extensions/apps-menu/extension.js
+++ b/extensions/apps-menu/extension.js
@@ -459,6 +459,8 @@ class ApplicationsButton extends PanelMenu.Button {
}
_onDestroy() {
+ super._onDestroy();
+
Main.overview.disconnect(this._showingId);
Main.overview.disconnect(this._hidingId);
appSys.disconnect(this._installedChangedId);
--
2.21.0