pool/luajit2
SHA256
19
0
Fork 1
Code Issues Pull Requests Activity

- Updated to 2.1.20250529 (1748495995). #1

Closed
13ilya wants to merge 10 commits from (deleted):main into factory
pull from: (deleted):main
merge into: pool:factory
Conversation 10 Commits 10 Files Changed 5 +13 -7
13ilya commented 2025-07-09 13:29:24 +02:00
First-time contributor
Copy Link
* Changed file luajit2-name.patch. * https://github.com/openresty/luajit2/compare/v2.1-20250117...v2.1-20250529
adamm commented 2025-07-09 13:32:45 +02:00
First-time contributor
Copy Link

so, the tarball is not in LFS. This has to be fixed in the devel project -- we'll need to rewrite history there to undo that change and replace it with LFS object.

so, the tarball is not in LFS. This has to be fixed in the devel project -- we'll need to rewrite history there to undo that change and replace it with LFS object.
adamm force-pushed main from da25981013 to f14ef0d82f 2025-07-09 13:37:45 +02:00 Compare
adamm commented 2025-07-09 13:39:52 +02:00
First-time contributor
Copy Link

I've fixed the LFS issue now

I've fixed the LFS issue now
13ilya commented 2025-07-09 13:55:24 +02:00
Author
First-time contributor
Copy Link

I'll try again with git-lfs

I'll try again with git-lfs
13ilya closed this pull request 2025-07-09 13:55:24 +02:00
adamm commented 2025-07-09 13:56:53 +02:00
First-time contributor
Copy Link

@13ilya it's already fixed in the force-push I did to the devel project, listed above 😉

@13ilya it's already fixed in the force-push I did to the devel project, listed above 😉
13ilya commented 2025-07-09 14:02:01 +02:00
Author
First-time contributor
Copy Link

@13ilya it's already fixed in the force-push I did to the devel project, listed above 😉

I don't understand something, if you fixed it, why am I still seeing this problem here?

https://src.opensuse.org/pool/luajit2/pulls/1/files

> @13ilya it's already fixed in the force-push I did to the devel project, listed above 😉 I don't understand something, if you fixed it, why am I still seeing this problem here? https://src.opensuse.org/pool/luajit2/pulls/1/files - version https://git-lfs.github.com/spec/v1 - oid sha256:68ff3dc2cc97969f7385679da7c9ff96738aa9cc275fa6bab77316eb3340ea8e - size 1163528
adamm commented 2025-07-09 14:11:01 +02:00
First-time contributor
Copy Link

Now it says (stored in LFS) instead of just binary file. If you click "view file" on the menu on the right, it will actually print,

f14ef0d82f/luajit2-2.1-20250529.tar.gz

version https://git-lfs.github.com/spec/v1
oid sha256:a3f6f5ead9fc69603e51c66877614e6b5e93332d552f35d08f932447357ed593
size 1164879

image.png

Now it says (stored in LFS) instead of just binary file. If you click "view file" on the menu on the right, it will actually print, https://src.opensuse.org/pool/luajit2/src/commit/f14ef0d82f260a15ab1cebad0e256abb6cbda0cba741d053912aed3bf2dc03c7/luajit2-2.1-20250529.tar.gz ``` version https://git-lfs.github.com/spec/v1 oid sha256:a3f6f5ead9fc69603e51c66877614e6b5e93332d552f35d08f932447357ed593 size 1164879 ``` ![image.png](/attachments/bfac4921-7fc8-48a0-a25a-311bba49ad7d)
image.png
35 KiB
adamm commented 2025-07-09 14:15:17 +02:00
First-time contributor
Copy Link

The problem is that Gitea UI, if it doesn't have access to the file, it will just print the text of the LFS pointer file. If it has access to the file, it will print "binary file not shown".

When we imported OBS repositories, we kept big files in OBS instead of duplicating many TB in Gitea LFS store. But Gitea doesn't really have access to OBS directly and so it just prints the LFS pointer file when the file is not in Gitea LFS store. It's mostly a UI issue.

The important thing here is we want to see the (Stored with Git LFS) indication.

The problem is that Gitea UI, if it doesn't have access to the file, it will just print the text of the LFS pointer file. If it has access to the file, it will print "binary file not shown". When we imported OBS repositories, we kept big files in OBS instead of duplicating many TB in Gitea LFS store. But Gitea doesn't really have access to OBS directly and so it just prints the LFS pointer file when the file is not in Gitea LFS store. It's mostly a UI issue. The important thing here is we want to see the **(Stored with Git LFS)** indication.
13ilya commented 2025-07-09 14:15:27 +02:00
Author
First-time contributor
Copy Link

Now it says (stored in LFS) instead of just binary file. If you click "view file" on the menu on the right, it will actually print,

Thank you, now I understand.

> Now it says (stored in LFS) instead of just binary file. If you click "view file" on the menu on the right, it will actually print, Thank you, now I understand.
13ilya commented 2025-07-09 14:39:32 +02:00
Author
First-time contributor
Copy Link

Please explain 1 more thing about package description and URL.

Now https://build.opensuse.org/package/show/openSUSE:Factory/luajit2 has description and URL because I added it earlier.

In https://src.opensuse.org/lua/luajit2 there is no description and URL of the package and I have no rights to add it.

After accepting #2 will it be removed from https://build.opensuse.org/package/show/openSUSE:Factory/luajit2 or it will not change?

Please explain 1 more thing about package description and URL. Now https://build.opensuse.org/package/show/openSUSE:Factory/luajit2 has description and URL because I added it earlier. In https://src.opensuse.org/lua/luajit2 there is no description and URL of the package and I have no rights to add it. After accepting https://src.opensuse.org/pool/luajit2/pulls/2 will it be removed from https://build.opensuse.org/package/show/openSUSE:Factory/luajit2 or it will not change?
adamm commented 2025-07-09 14:46:59 +02:00
First-time contributor
Copy Link

I've given you admin rights to the repo in the lua org's luajit2 package, so you can set the description there too.

Descriptions in openSUSE:Factory OBS project will not be removed or altered. Once the project is itself in Git, then the package meta in OBS will disappear and be generated only. OBS will look like this,

https://build.opensuse.org/project/show/devel:languages:lua

and package meta will look like,

osc meta pkg devel:languages:lua luajit2

<package name="luajit2" project="devel:languages:lua">
  <scmsync>https://src.opensuse.org/lua/luajit2.git#f14ef0d82f260a15ab1cebad0e256abb6cbda0cba741d053912aed3bf2dc03c7</scmsync>
  <url>https://src.opensuse.org/lua/_ObsPrj.git</url>
</package>
I've given you admin rights to the repo in the lua org's luajit2 package, so you can set the description there too. Descriptions in openSUSE:Factory OBS project will not be removed or altered. Once the project is itself in Git, then the package meta in OBS will disappear and be generated only. OBS will look like this, https://build.opensuse.org/project/show/devel:languages:lua and package meta will look like, `osc meta pkg devel:languages:lua luajit2` ``` <package name="luajit2" project="devel:languages:lua"> <scmsync>https://src.opensuse.org/lua/luajit2.git#f14ef0d82f260a15ab1cebad0e256abb6cbda0cba741d053912aed3bf2dc03c7</scmsync> <url>https://src.opensuse.org/lua/_ObsPrj.git</url> </package> ```

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
legaldb
Critical Priority
Critical legaldb priority
Archived
legaldb
High Priority
2
High legaldb priority
legaldb
Normal Priority
1
Normal legaldb priority
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
adamm_super adrianSuSE autobuild-owner autobuild-review autogits_workflow_pr_bot bigironman dirkmueller eroca factory_bot gitea_test legaldb lkocman-factory maxlin_factory opensuse-review packagehub-review smithfarm
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pool/luajit2#1
Delete Branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?