Accepting request 735823 from GNOME:Next

New stable rel

OBS-URL: https://build.opensuse.org/request/show/735823
OBS-URL: https://build.opensuse.org/package/show/GNOME:Factory/nautilus?expand=0&rev=319
This commit is contained in:
Dominique Leuenberger 2019-10-07 14:50:24 +00:00 committed by Git OBS Bridge
parent a0bf6930d6
commit 288d02aeb6
5 changed files with 14 additions and 41 deletions

View File

@ -1,3 +0,0 @@
version https://git-lfs.github.com/spec/v1
oid sha256:666494ec976688d9500123c77b77fdfb882e7e3b3520f9bdb869c9ae2a2c9ad9
size 3182260

3
nautilus-3.34.1.tar.xz Normal file
View File

@ -0,0 +1,3 @@
version https://git-lfs.github.com/spec/v1
oid sha256:37ce2c16a610c589dcc7660f9092446465568e38e29bce6ed8c24f2e8e0077f3
size 3181312

View File

@ -1,35 +0,0 @@
From 668e0673a7ea3fe4cb6c99bc7b56bc52597e2061 Mon Sep 17 00:00:00 2001
From: Ondrej Holy <oholy@redhat.com>
Date: Wed, 25 Sep 2019 09:16:44 +0200
Subject: [PATCH] window: Fix criticals when moving file to trash
The "gtk_revealer_get_transition_type: assertion 'GTK_IS_REVEALER (revealer)'
failed" critical is printed when moving file to trash after closing a window.
This is because the "undo-changed" signal handler is not disconnected when
the window is destroyed. Let's use g_signal_connect_object() to ensure
disconnection and prevent those criticals.
Fixes: https://gitlab.gnome.org/GNOME/nautilus/issues/1076
---
src/nautilus-window.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/nautilus-window.c b/src/nautilus-window.c
index 285a6a6ce..056c75c7a 100644
--- a/src/nautilus-window.c
+++ b/src/nautilus-window.c
@@ -2239,8 +2239,9 @@ nautilus_window_constructed (GObject *self)
nautilus_window_set_up_sidebar (window);
- g_signal_connect_after (nautilus_file_undo_manager_get (), "undo-changed",
- G_CALLBACK (nautilus_window_on_undo_changed), self);
+ g_signal_connect_object (nautilus_file_undo_manager_get (), "undo-changed",
+ G_CALLBACK (nautilus_window_on_undo_changed), self,
+ G_CONNECT_AFTER);
/* Is required that the UI is constructed before initializating the actions, since
* some actions trigger UI widgets to show/hide. */
--
2.22.0

View File

@ -1,3 +1,13 @@
-------------------------------------------------------------------
Mon Oct 7 11:55:59 UTC 2019 - Bjørn Lie <bjorn.lie@gmail.com>
- Update to version 3.34.1:
+ Fix criticals and crashes when closing properties dialog.
+ Fix opening file previews in Sushi.
+ Fix criticals after trashing file.
- Drop nautilus-fix-criticals-move-file-trash.patch: Fixed
upstream.
-------------------------------------------------------------------
Thu Sep 26 12:39:50 UTC 2019 - Bjørn Lie <bjorn.lie@gmail.com>

View File

@ -17,7 +17,7 @@
Name: nautilus
Version: 3.34.0
Version: 3.34.1
Release: 0
Summary: File Manager for the GNOME Desktop
License: GPL-3.0-or-later AND LGPL-2.1-or-later
@ -30,8 +30,6 @@ Source1: mount-archive.desktop
Source2: set_trusted.desktop
Source3: set_trusted.sh
Source99: baselibs.conf
# PATCH-FIX-UPSTREAM nautilus-fix-criticals-move-file-trash.patch -- window: Fix criticals when moving file to trash
Patch0: nautilus-fix-criticals-move-file-trash.patch
# needed for directory ownership
BuildRequires: dbus-1